lib: use primordials when calling methods of Error global object #35837
+23
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
|
Should we add a test that crashes things now but won't crash with this change? |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
|
Shouldn't we use primordials instead? |
This is to unsure that code using those methods won't crash if the methods are deleted in userland.
Actually we can. I don't know why I had the preconceived notion that
@Trott Is it still needed now that I'm using primordials? |
aduh95
force-pushed
the
error-prototype-optional-chaining
branch
from
9455338
to
b642e52
Compare
aduh95
changed the title
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
3 tasks
targos
approved these changes
Oct 28, 2020
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Oct 28, 2020
aduh95
added
the
author ready
Leko
approved these changes
Oct 28, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 05bb1b3...1da6729 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2020
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
This is to unsure that code using those methods won't crash if the methods are deleted in userland. PR-URL: #35837 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unsure that code using those methods won't crash if the
methods are deleted in userland.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes