Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to cjs-module-lexer@0.5.2 #35901

Closed
wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 31, 2020

This updates to cjs-module-lexer@0.5.2, with the patches to improve the getter detection over the previous global opt-out of getters to specifically match the exact forms used by the Babel (and RollupJS and other build tool) getter output for reexports in strict conversions, implemented in nodejs/cjs-module-lexer#25 and nodejs/cjs-module-lexer#26.

This fixes the regression in #35893.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@guybedford
Copy link
Contributor Author

I'd like to request a fast track for this PR.

@nodejs-github-bot
Copy link
Collaborator

@guybedford
Copy link
Contributor Author

Ping @nodejs/modules-active-members for review.

@aduh95
Copy link
Contributor

aduh95 commented Oct 31, 2020

This fixes the regression in #35893.

I'm still able to reproduce the related issue when applying the patch from this PR… Am I missing something?

@guybedford guybedford changed the title deps: update to cjs-module-lexer@0.5.1 deps: update to cjs-module-lexer@0.5.2 Oct 31, 2020
@guybedford
Copy link
Contributor Author

@aduh95 thanks so much for checking this, I've updated the PR to a 0.5.2 supporting named getter functions, it's working now for the example I can confirm.

@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented Oct 31, 2020

Yes, I can confirm the new version solves the issue 🎉

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 31, 2020
guybedford added a commit that referenced this pull request Nov 1, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@guybedford
Copy link
Contributor Author

Landed in 5735525.

@guybedford guybedford closed this Nov 1, 2020
@guybedford guybedford deleted the lexer-update branch November 1, 2020 01:43
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35901
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants