Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: bump remark to 13.0.0 for markdown linter rollup #35905

Merged
merged 0 commits into from
Nov 3, 2020
Merged

tools,doc: bump remark to 13.0.0 for markdown linter rollup #35905

merged 0 commits into from
Nov 3, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 1, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/quic
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 1, 2020
@targos
Copy link
Member

targos commented Nov 1, 2020

All those disable comments suggest that remark should maybe ignore tables or have an option for that

@targos
Copy link
Member

targos commented Nov 2, 2020

https://github.com/remarkjs/remark/releases/tag/13.0.0

The changelog says that for tables we need remark-gfm. Do we have it?

targos
targos requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so my question is not missed

@Trott

This comment has been minimized.

Sign in to view
@Trott

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Nov 2, 2020

https://github.com/remarkjs/remark/releases/tag/13.0.0
The changelog says that for tables we need remark-gfm. Do we have it?

That's if you're using remark to render markdown to HTML. Here, we're using it to lint only. As far as I can tell, remark-gfm is unused in remark-lint.

Oops nope, I'm wrong.

All those disable comments suggest that remark should maybe ignore tables or have an option for that

This would seem to be either a bug or a new feature in remark-lint-maximum-line-length as the README currently says it is supposed to exclude tables. I'm guessing that the code to detect/exclude lines in tables is somehow broken when using remark@13 to parse.

And oops nope, I'm wrong here too.

Will get GFM enabled. Might involve updating remark-preset-lint-node though.

@Trott
Copy link
Member Author

Trott commented Nov 3, 2020

This is blocked on #35934.

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Nov 3, 2020
@Trott
Copy link
Member Author

Trott commented Nov 3, 2020 •
edited
Loading

@targos Your comments have been addressed. While the comments were spot-on, unfortunately they also mean this will now fail until:

Those four things must happen in that order.

@Trott
Copy link
Member Author

Trott commented Nov 3, 2020

OK, all done. PTAL, especially @targos!

@Trott Trott mentioned this pull request Nov 3, 2020
Merged
Trott added a commit that referenced this pull request Nov 3, 2020
@Trott
doc: update tables in README files for linting changes
adfcade 
PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 3, 2020

Landed in 1a29c09...1bc1f84

@Trott Trott closed this Nov 3, 2020
@Trott Trott deleted the remark-13 branch November 3, 2020 13:19
@Trott Trott merged commit 1bc1f84 into nodejs:master Nov 3, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
@Trott @targos
doc: update tables in README files for linting changes
7937fbe 
PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Nov 3, 2020
@Trott @targos
tools: bump remark-lint-preset-node to 2.0.0
fd027cd 
Update remark@13.0.0, remark-lint-preset-node@2.0.0 and other
dependencies in the lint-md rollup.

PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@Trott @BethGriggs
doc: update tables in README files for linting changes
4907af1 
PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
doc: update tables in README files for linting changes
5c3e56b 
PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
doc: update tables in README files for linting changes
51ce1a2 
PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
tools: bump remark-lint-preset-node to 2.0.0
ac70a59 
Update remark@13.0.0, remark-lint-preset-node@2.0.0 and other
dependencies in the lint-md rollup.

PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Trott @danielleadams
tools: bump remark-lint-preset-node to 2.0.0
7715fb4 
Update remark@13.0.0, remark-lint-preset-node@2.0.0 and other
dependencies in the lint-md rollup.

PR-URL: #35905
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@codebytere codebytere codebytere approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @targos @fhinkel @codebytere