-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: fix trace_events name for resolveCaa() #35979
Conversation
Review requested:
|
Whoops, that was against master and shows the failure. Here's against this PR to show success: Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17425/ ✅ |
@nodejs/testing @nodejs/dns This fixes the node-daily-master CI job. One more review/approval would be helpful. |
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: nodejs#35979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in 642174a |
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: #35979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
A test was added for this in 6f34498 but because it was a test in the `internet` directory, it was not run on CI and it was not noticed that the test was failing. This fixes the error that was causing the test to fail. PR-URL: #35979 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
A test was added for this in 6f34498 but because it was a test in the
internet
directory, it was not run on CI and it was not noticed thatthe test was failing. This fixes the error that was causing the test to
fail.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes