Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-word project messaging #36

Closed
wants to merge 1 commit into from

Conversation

kevinohara80
Copy link
Contributor

The previous paragraph was good but a little unclear. This fixes that.

@Fishrock123
Copy link
Contributor

LGTM, though I think io.js looks nicer as io.js.

@kevinohara80
Copy link
Contributor Author

@Fishrock123 done ^^

@kevinohara80 kevinohara80 changed the title docs: re-word project messaging #24 docs: re-word project messaging Dec 3, 2014
@rvagg
Copy link
Member

rvagg commented Dec 4, 2014

"io.js" isn't a programatic name so I'm -1 on io.js, I'd hate for that to become the norm for how it's written

@rvagg rvagg force-pushed the v0.12 branch 4 times, most recently from d7e65ff to 185d11c Compare December 4, 2014 10:21
@Fishrock123
Copy link
Contributor

Yeah Rod is correct, I'm just silly.

@kevinohara80
Copy link
Contributor Author

@rvagg I just removed the back ticks. Agree that formatting should be reserved for programatic items.

@indutny
Copy link
Member

indutny commented Dec 10, 2014

@Fishrock123 @rvagg are we good with this?

@rvagg
Copy link
Member

rvagg commented Dec 10, 2014

sure, the line breaks bother me but that's not a big deal

LGTM

@bnoordhuis
Copy link
Member

I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great.

@kevinohara80
Copy link
Contributor Author

No problem. I'll do this today.

On Wednesday, Dec 10, 2014 at 7:43 AM, Ben Noordhuis notifications@github.com, wrote:

I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great.


Reply to this email directly or view it on GitHub.

@kevinohara80
Copy link
Contributor Author

@bnoordhuis @rvagg Rebased and removed whitespace to make it a single paragraph. Let me know if there's any other tweaks.

@bnoordhuis
Copy link
Member

Sorry, I didn't notice it's spread out over multiple commits. Can you squash them and make the commit log conform to what is outlined in CONTRIBUTING.md? git log README.md shows examples. Thanks!

rewords project messaging in README to make the overall
project messaging a bit clearer. More discussion to be
found in nodejs#24
@kevinohara80
Copy link
Contributor Author

@bnoordhuis My bad. Does this look good?

bnoordhuis pushed a commit that referenced this pull request Dec 10, 2014
Rewords project messaging in README to make the overall project
messaging a bit clearer. More discussion to be found in #24.

PR-URL: #36
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis
Copy link
Member

Looks great, Kevin. Landed in 6f1d0a8, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants