test: replace var statements by let statements #36069

arsenalzp · 2020-11-10T16:52:48Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Trott · 2020-11-10T16:54:09Z

Seems to me these could be const?

arsenalzp · 2020-11-10T18:21:56Z

Seems to me these could be const?
Hello,
Thank you for remark.
I took it into account and replaced let statement by const statement.

Trott · 2020-11-11T14:32:52Z

lib/internal/streams/pipeline.js

@@ -269,7 +269,7 @@ function pipeline(...streams) {
    } else {
      const name = reading ? `transform[${i - 1}]` : 'destination';
      throw new ERR_INVALID_ARG_TYPE(
-        name, ['Stream', 'Function'], ret);
+        name, ['Stream', 'Function'], stream);


Unrelated change?

I rebased and that fixed this.

nodejs-github-bot · 2020-11-11T14:36:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34329/

Trott · 2020-11-12T02:00:26Z

Might you be using git merge or git pull rather than git rebase? It keeps including other folks' commits and adding in merge commits, both of which mess up our tooling. (Not your fault. Our tooling is picky.) See instructions at https://github.com/nodejs/node/blob/35274cbddf7206687b2e30d32e57d293750e19a0/doc/guides/contributing/pull-requests.md#step-5-rebase

Trott · 2020-11-12T02:04:20Z

Rebased and squashed.

nodejs-github-bot · 2020-11-12T02:19:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34355/

github-actions · 2020-11-12T04:46:12Z

Commit Queue failed

- Loading data for nodejs/node/pull/36069
✔  Done loading data for nodejs/node/pull/36069
----------------------------------- PR info ------------------------------------
Title      test: replace var statements by let statements (#36069)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     arsenalzp:my-branch -> nodejs:master
Labels     test
Commits    1
 - test: replace var with const
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/36069
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36069
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-12T02:19:31Z: https://ci.nodejs.org/job/node-test-pull-request/34355/
- Querying data for job/node-test-pull-request/34355/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Tue, 10 Nov 2020 16:52:48 GMT
   ✔  Approvals: 4
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36069#pullrequestreview-527551478
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/36069#pullrequestreview-527721413
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36069#pullrequestreview-528226897
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/36069#pullrequestreview-528741408
   ✖  This PR needs to wait 12 more hours to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/359025849

Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: nodejs#36069 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Trott · 2020-11-13T14:11:55Z

Landed in e4507e5

Replace `var` with `const` in vm context for test-util-inspect.js. PR-URL: #36069 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2020

benjamingr approved these changes Nov 10, 2020

View reviewed changes

watilde approved these changes Nov 11, 2020

View reviewed changes

Trott reviewed Nov 11, 2020

View reviewed changes

Trott force-pushed the my-branch branch from 9f39a10 to 1d81ce2 Compare November 11, 2020 14:34

Trott approved these changes Nov 11, 2020

View reviewed changes

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2020

Trott force-pushed the my-branch branch from 3e25a03 to 2748f79 Compare November 12, 2020 02:04

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2020

gireeshpunathil approved these changes Nov 12, 2020

View reviewed changes

gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2020

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 12, 2020

Trott force-pushed the my-branch branch from 2748f79 to 92d85ef Compare November 13, 2020 14:09

Trott force-pushed the my-branch branch from 92d85ef to ce2c3da Compare November 13, 2020 14:10

Trott force-pushed the my-branch branch from ce2c3da to e4507e5 Compare November 13, 2020 14:11

Trott merged commit e4507e5 into nodejs:master Nov 13, 2020

arsenalzp deleted the my-branch branch November 14, 2020 14:10

codebytere mentioned this pull request Nov 22, 2020

v15.3.0 proposal #36232

Merged

BethGriggs mentioned this pull request Dec 10, 2020

v14.15.2 proposal #36476

Merged

targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: replace var statements by let statements #36069

test: replace var statements by let statements #36069

arsenalzp commented Nov 10, 2020

Trott commented Nov 10, 2020

arsenalzp commented Nov 10, 2020

Trott Nov 11, 2020

Trott Nov 11, 2020

nodejs-github-bot commented Nov 11, 2020

Trott commented Nov 12, 2020 •

edited

Loading

Trott commented Nov 12, 2020

nodejs-github-bot commented Nov 12, 2020

github-actions bot commented Nov 12, 2020 •

edited by aduh95

Loading

Trott commented Nov 13, 2020

test: replace var statements by let statements #36069

test: replace var statements by let statements #36069

Conversation

arsenalzp commented Nov 10, 2020

Checklist

Trott commented Nov 10, 2020

arsenalzp commented Nov 10, 2020

Trott Nov 11, 2020

Choose a reason for hiding this comment

Trott Nov 11, 2020

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 11, 2020

Trott commented Nov 12, 2020 • edited Loading

Trott commented Nov 12, 2020

nodejs-github-bot commented Nov 12, 2020

github-actions bot commented Nov 12, 2020 • edited by aduh95 Loading

Trott commented Nov 13, 2020

Trott commented Nov 12, 2020 •

edited

Loading

github-actions bot commented Nov 12, 2020 •

edited by aduh95

Loading