Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: improve deprecation warning text for DEP0097 #36136

Closed
wants to merge 1 commit into from
Closed

domain: improve deprecation warning text for DEP0097 #36136

wants to merge 1 commit into from

Commits on Nov 16, 2020

  1. domain: improve deprecation warning text for DEP0097 

    Because the following gives basically no actionable information
on its own, neither in the error message nor in the stack trace:

    (node:3187) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
        at emitMakeCallbackDeprecation (domain.js:123:13)
        at process.topLevelDomainCallback (domain.js:135:5)
        at process.callbackTrampoline (internal/async_hooks.js:124:14)
    @addaleax
    addaleax committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    f194b43 View commit details
    Browse the repository at this point in the history