error: refactor to use more primordials #36167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
jasnell
approved these changes
Nov 19, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
trivikr
approved these changes
Nov 20, 2020
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36167 ✔ Done loading data for nodejs/node/pull/36167 ----------------------------------- PR info ------------------------------------ Title error: refactor to use more primordials (#36167) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:error-prefer-primordials -> nodejs:master Labels author ready, errors Commits 2 - error: refactor to use more primordials - fixup! error: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36167 Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-19T15:29:46Z: https://ci.nodejs.org/job/node-test-pull-request/34468/ - Querying data for job/node-test-pull-request/34468/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Wed, 18 Nov 2020 19:03:39 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36167#pullrequestreview-534523144 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/36167#pullrequestreview-535143757 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36167 From https://github.com/nodejs/node * branch refs/pull/36167/merge -> FETCH_HEAD ✔ Fetched commits as 514f464a600f..86a97e77131b -------------------------------------------------------------------------------- Auto-merging lib/internal/errors.js [master e8aed38623] error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 10:57:14 2020 +0100 1 file changed, 5 insertions(+), 3 deletions(-) [master 364cbb53c3] fixup! error: refactor to use more primordials Author: Antoine du Hamel Date: Wed Nov 18 23:04:31 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/3) Rebasing (3/3)https://github.com/nodejs/node/actions/runs/375072234 |
PR-URL: nodejs#36167 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
force-pushed
the
error-prefer-primordials
branch
from
86a97e7
to
893d8a6
Compare
|
Landed in 893d8a6 |
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36167 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36167 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36167 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes