Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: update node.rc file description #36197

Merged
merged 1 commit into from
Nov 23, 2020
Merged

src: update node.rc file description #36197

merged 1 commit into from
Nov 23, 2020

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Nov 20, 2020 •
edited
Loading

This is the name that appears in task manager by default

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2020
@devsnek devsnek added lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform. request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Nov 20, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34492/

@devsnek devsnek added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-20T19:56:01Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379142842

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 23, 2020
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 23, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-23T14:48:32Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379156320

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 23, 2020
@devsnek
src: update node.rc file description
b5d9bd5 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@devsnek devsnek merged commit b5d9bd5 into master Nov 23, 2020
@devsnek
Copy link
Member Author

devsnek commented Nov 23, 2020

landed in b5d9bd5

@devsnek devsnek deleted the devsnek-patch-1 branch November 23, 2020 15:27
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@devsnek @danielleadams
src: update node.rc file description
47397ff 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@devsnek @targos
src: update node.rc file description
d8cb341 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@devsnek @nodejs-github-bot @Trott @addaleax @lpinca @targos @cjihrig @gengjiawen @aduh95 @Flarna