Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: refactor to use more primordials #36234

Merged
merged 0 commits into from
Nov 27, 2020
Merged

assert: refactor to use more primordials #36234

merged 0 commits into from
Nov 27, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 23, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Nov 23, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34554/

@Trott
Copy link
Member

Trott commented Nov 25, 2020

Benchmarks (queued): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/708/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-benchmark-ci PR that need a benchmark CI run. labels Nov 25, 2020
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 25, 2020

Benchmark results:

                                                                                                                        confidence improvement accuracy (*)    (**)   (***)
assert/deepequal-buffer.js method='deepEqual' strict=0 len=1000 n=20000                                                         **     -7.52 %       ±4.88%  ±6.53%  ±8.58%
assert/deepequal-map.js method='deepEqual_mixed' strict=0 len=500 n=500                                                          *      2.07 %       ±1.82%  ±2.43%  ±3.17%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                       *     -4.10 %       ±3.59%  ±4.78%  ±6.23%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='array'             *     -7.27 %       ±5.86%  ±7.81% ±10.21%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='object'            *     -7.24 %       ±6.01%  ±8.01% ±10.46%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='object'                               *     -5.64 %       ±4.64%  ±6.18%  ±8.06%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                       *     -5.43 %       ±4.57%  ±6.08%  ±7.92%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                               *     -4.01 %       ±3.83%  ±5.10%  ±6.65%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float32Array'                                  **      6.03 %       ±4.45%  ±5.92%  ±7.71%

                                                                                                                        confidence improvement accuracy (*)    (**)   (***)
assert/deepequal-buffer.js method='deepEqual' strict=0 len=1000 n=20000                                                         **     -7.52 %       ±4.88%  ±6.53%  ±8.58%
assert/deepequal-buffer.js method='deepEqual' strict=0 len=100 n=20000                                                                 -1.50 %       ±4.17%  ±5.55%  ±7.22%
assert/deepequal-buffer.js method='deepEqual' strict=1 len=1000 n=20000                                                                -0.74 %       ±5.91%  ±7.86% ±10.23%
assert/deepequal-buffer.js method='deepEqual' strict=1 len=100 n=20000                                                                 -0.26 %       ±5.99%  ±7.97% ±10.38%
assert/deepequal-buffer.js method='notDeepEqual' strict=0 len=1000 n=20000                                                              1.86 %       ±4.39%  ±5.87%  ±7.69%
assert/deepequal-buffer.js method='notDeepEqual' strict=0 len=100 n=20000                                                              -0.83 %       ±4.15%  ±5.53%  ±7.20%
assert/deepequal-buffer.js method='notDeepEqual' strict=1 len=1000 n=20000                                                              2.36 %       ±4.70%  ±6.25%  ±8.14%
assert/deepequal-buffer.js method='notDeepEqual' strict=1 len=100 n=20000                                                              -5.10 %       ±6.35%  ±8.46% ±11.05%
assert/deepequal-map.js method='deepEqual_mixed' strict=0 len=500 n=500                                                          *      2.07 %       ±1.82%  ±2.43%  ±3.17%
assert/deepequal-map.js method='deepEqual_mixed' strict=1 len=500 n=500                                                                 0.30 %       ±1.85%  ±2.47%  ±3.23%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                           -2.88 %       ±4.56%  ±6.13%  ±8.11%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                           -0.23 %       ±1.62%  ±2.16%  ±2.83%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                         0.52 %       ±4.52%  ±6.02%  ±7.83%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                        -0.65 %       ±3.05%  ±4.06%  ±5.30%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                              0.73 %       ±4.73%  ±6.33%  ±8.30%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                       *     -4.10 %       ±3.59%  ±4.78%  ±6.23%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                         0.81 %       ±1.71%  ±2.29%  ±3.00%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                        -0.31 %       ±1.81%  ±2.41%  ±3.14%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                     -0.65 %       ±3.25%  ±4.33%  ±5.64%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                     -0.15 %       ±2.71%  ±3.61%  ±4.70%
assert/deepequal-object.js method='deepEqual' strict=0 size=1000 n=5000                                                                 3.23 %       ±6.10%  ±8.12% ±10.57%
assert/deepequal-object.js method='deepEqual' strict=0 size=100 n=5000                                                                  2.97 %       ±6.37%  ±8.50% ±11.12%
assert/deepequal-object.js method='deepEqual' strict=0 size=50000 n=5000                                                               -0.19 %       ±3.17%  ±4.27%  ±5.66%
assert/deepequal-object.js method='deepEqual' strict=1 size=1000 n=5000                                                                -0.14 %       ±6.49%  ±8.64% ±11.24%
assert/deepequal-object.js method='deepEqual' strict=1 size=100 n=5000                                                                 -2.74 %       ±5.79%  ±7.73% ±10.10%
assert/deepequal-object.js method='deepEqual' strict=1 size=50000 n=5000                                                                0.22 %       ±1.20%  ±1.60%  ±2.10%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=1000 n=5000                                                             -0.31 %       ±9.59% ±12.77% ±16.64%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=100 n=5000                                                               3.05 %       ±8.78% ±11.69% ±15.23%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=50000 n=5000                                                             1.53 %       ±3.26%  ±4.34%  ±5.65%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=1000 n=5000                                                              1.82 %       ±8.78% ±11.69% ±15.21%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=100 n=5000                                                               3.86 %       ±9.44% ±12.56% ±16.35%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=50000 n=5000                                                             0.31 %       ±1.56%  ±2.07%  ±2.70%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='array'                     3.77 %       ±4.54%  ±6.04%  ±7.86%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='number'                    2.59 %       ±4.58%  ±6.11%  ±7.97%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='object'                    1.44 %       ±5.93%  ±7.89% ±10.28%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='string'                   -1.64 %       ±4.13%  ±5.50%  ±7.16%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='array'                     0.03 %       ±5.14%  ±6.84%  ±8.91%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='number'                    5.59 %       ±7.27%  ±9.69% ±12.64%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='object'                   -4.82 %       ±5.20%  ±6.92%  ±9.01%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='string'                   -2.10 %       ±4.80%  ±6.41%  ±8.37%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='array'                      -0.41 %       ±6.32%  ±8.40% ±10.94%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='number'                      0.27 %       ±5.55%  ±7.38%  ±9.62%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='object'                      1.61 %       ±7.07%  ±9.46% ±12.41%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='string'                      2.09 %       ±6.29%  ±8.37% ±10.90%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='array'                       5.02 %       ±6.03%  ±8.04% ±10.50%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='number'                      3.23 %       ±7.28%  ±9.71% ±12.67%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='object'                      4.85 %       ±6.62%  ±8.85% ±11.61%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='string'                      3.69 %       ±6.91%  ±9.21% ±12.02%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='array'                 -3.94 %       ±5.19%  ±6.90%  ±8.99%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='number'                 1.26 %       ±3.78%  ±5.04%  ±6.56%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='object'                -1.48 %       ±4.65%  ±6.19%  ±8.05%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='string'                 0.49 %       ±3.20%  ±4.26%  ±5.54%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='array'                  1.60 %       ±4.77%  ±6.37%  ±8.32%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='number'                 1.82 %       ±4.91%  ±6.53%  ±8.51%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='object'                -4.12 %       ±5.04%  ±6.71%  ±8.73%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='string'                -0.90 %       ±4.50%  ±5.99%  ±7.80%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='array'                   -3.41 %       ±5.93%  ±7.90% ±10.30%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='number'                  -0.18 %       ±6.63%  ±8.83% ±11.49%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='object'                  -1.85 %       ±7.14%  ±9.52% ±12.41%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='string'                  -0.55 %       ±6.38%  ±8.50% ±11.07%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='array'             *     -7.27 %       ±5.86%  ±7.81% ±10.21%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='number'                   0.90 %       ±9.22% ±12.27% ±15.97%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='object'            *     -7.24 %       ±6.01%  ±8.01% ±10.46%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='string'                   4.84 %       ±5.42%  ±7.21%  ±9.39%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='array'                                      -3.88 %       ±6.09%  ±8.12% ±10.58%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='number'                                     -2.31 %       ±4.14%  ±5.52%  ±7.20%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='object'                                     -2.68 %       ±4.52%  ±6.01%  ±7.83%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='string'                                     -0.79 %       ±3.49%  ±4.64%  ±6.04%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='array'                                       2.85 %       ±3.86%  ±5.13%  ±6.68%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='number'                                     -2.29 %       ±4.14%  ±5.51%  ±7.18%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='object'                               *     -5.64 %       ±4.64%  ±6.18%  ±8.06%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='string'                                     -2.76 %       ±4.88%  ±6.53%  ±8.55%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='array'                                   -4.13 %       ±6.06%  ±8.07% ±10.50%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='number'                                  -3.57 %       ±5.01%  ±6.69%  ±8.75%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='object'                                  -2.36 %       ±4.88%  ±6.50%  ±8.47%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='string'                                   0.42 %       ±3.94%  ±5.25%  ±6.83%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='array'                                   -2.90 %       ±4.65%  ±6.19%  ±8.08%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='number'                                  -1.49 %       ±4.35%  ±5.80%  ±7.57%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='object'                                  -0.19 %       ±4.30%  ±5.72%  ±7.45%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='string'                                   1.70 %       ±4.65%  ±6.19%  ±8.08%
assert/deepequal-set.js method='deepEqual_mixed' strict=0 len=500 n=500                                                                 0.73 %       ±1.96%  ±2.61%  ±3.40%
assert/deepequal-set.js method='deepEqual_mixed' strict=1 len=500 n=500                                                                -0.79 %       ±2.19%  ±2.92%  ±3.80%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                           -0.51 %       ±1.72%  ±2.29%  ±2.98%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                            1.14 %       ±1.33%  ±1.77%  ±2.30%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                         1.28 %       ±5.70%  ±7.58%  ±9.87%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                         3.05 %       ±4.97%  ±6.62%  ±8.61%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                              2.41 %       ±5.41%  ±7.20%  ±9.38%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                       *     -5.43 %       ±4.57%  ±6.08%  ±7.92%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                         0.28 %       ±2.52%  ±3.35%  ±4.36%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                         2.71 %       ±5.20%  ±6.97%  ±9.19%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                               *     -4.01 %       ±3.83%  ±5.10%  ±6.65%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                      1.22 %       ±3.76%  ±5.00%  ±6.52%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Float32Array'                                           0.60 %       ±4.85%  ±6.46%  ±8.40%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Float64Array'                                          -0.55 %       ±3.91%  ±5.21%  ±6.79%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Int8Array'                                              0.75 %       ±6.77%  ±9.01% ±11.73%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint8Array'                                            -0.57 %       ±6.00%  ±7.99% ±10.40%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint8ClampedArray'                                      0.39 %       ±5.16%  ±6.86%  ±8.94%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Float32Array'                                           2.19 %       ±6.31%  ±8.40% ±10.94%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Float64Array'                                           4.79 %       ±5.69%  ±7.60%  ±9.93%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Int8Array'                                              3.43 %       ±4.77%  ±6.35%  ±8.27%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint8Array'                                             3.41 %       ±5.11%  ±6.80%  ±8.88%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint8ClampedArray'                                     -3.84 %       ±7.30%  ±9.72% ±12.66%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                       -2.83 %       ±4.59%  ±6.11%  ±7.98%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Float64Array'                                        2.30 %       ±5.92%  ±7.93% ±10.44%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                           1.59 %       ±5.44%  ±7.25%  ±9.46%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                         -3.65 %       ±4.72%  ±6.28%  ±8.17%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint8ClampedArray'                                  -3.26 %       ±7.22%  ±9.61% ±12.51%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                        4.69 %       ±8.40% ±11.19% ±14.59%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Float64Array'                                       -0.33 %       ±5.06%  ±6.74%  ±8.78%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                           0.37 %       ±6.49%  ±8.64% ±11.27%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                          3.06 %       ±6.53%  ±8.69% ±11.32%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint8ClampedArray'                                  -6.61 %      ±10.57% ±14.18% ±18.70%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float32Array'                                  **      6.03 %       ±4.45%  ±5.92%  ±7.71%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float64Array'                                          0.83 %       ±3.18%  ±4.24%  ±5.53%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Int8Array'                                             3.55 %       ±6.44%  ±8.60% ±11.26%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint8Array'                                            2.34 %       ±5.46%  ±7.27%  ±9.49%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint8ClampedArray'                                    -1.61 %       ±6.06%  ±8.07% ±10.53%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Float32Array'                                         -1.82 %       ±5.44%  ±7.24%  ±9.43%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Float64Array'                                         -0.80 %       ±5.25%  ±6.99%  ±9.10%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Int8Array'                                             2.86 %       ±7.18%  ±9.56% ±12.45%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint8Array'                                           -0.56 %       ±6.13%  ±8.16% ±10.62%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint8ClampedArray'                                    -2.61 %       ±5.14%  ±6.84%  ±8.90%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                      -1.37 %       ±4.94%  ±6.58%  ±8.57%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Float64Array'                                      -2.51 %       ±6.39%  ±8.51% ±11.10%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                         -0.03 %       ±5.19%  ±6.91%  ±9.01%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                         2.74 %       ±7.89% ±10.49% ±13.66%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint8ClampedArray'                                  2.21 %       ±6.23%  ±8.30% ±10.80%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                       4.11 %       ±6.87%  ±9.18% ±12.04%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Float64Array'                                       3.26 %       ±4.79%  ±6.38%  ±8.33%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                          3.95 %       ±5.70%  ±7.58%  ±9.87%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                        -1.33 %       ±5.37%  ±7.16%  ±9.34%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint8ClampedArray'                                 -2.88 %       ±5.87%  ±7.82% ±10.21%
assert/ok.js n=100000                                                                                                                  -0.72 %       ±3.61%  ±4.80%  ±6.25%
assert/throws.js method='doesNotThrow' n=10000                                                                                         -2.34 %       ±6.37%  ±8.49% ±11.08%
assert/throws.js method='throws_RegExp' n=10000                                                                                        -4.44 %       ±4.44%  ±5.93%  ±7.74%
assert/throws.js method='throws_TypeError' n=10000                                                                                     -3.19 %       ±3.96%  ±5.27%  ±6.86%

@Trott Trott closed this Nov 27, 2020
@Trott Trott merged commit 709b339 into nodejs:master Nov 27, 2020
@Trott
Copy link
Member

Trott commented Nov 27, 2020

Landed in 709b339

@aduh95 aduh95 deleted the assert-primordials branch November 27, 2020 14:23
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
assert: refactor to use more primordials
e79bdc3 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
assert: refactor to use more primordials
ca7417e 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 31, 2021
@aduh95 @targos
assert: refactor to use more primordials
74ab205 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
assert: refactor to use more primordials
9999656 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
assert: refactor to use more primordials
f807ee0 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
assert: refactor to use more primordials
87fa636 
PR-URL: #36234
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-benchmark-ci PR that need a benchmark CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @Trott @jasnell @targos