fs: pass the error if directory already closed #36243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
targos
reviewed
Nov 24, 2020
Lxxyx
force-pushed
the
fix/dir-close-throws
branch
from
65a8561
to
cb6b8a2
Compare
aduh95
reviewed
Nov 24, 2020
Lxxyx
force-pushed
the
fix/dir-close-throws
branch
from
cb6b8a2
to
b0b499f
Compare
|
Thanks for the Review, changes have been pushed. @aduh95 |
aduh95
approved these changes
Nov 24, 2020
joyeecheung
approved these changes
Nov 24, 2020
aduh95
reviewed
Nov 24, 2020
Lxxyx
force-pushed
the
fix/dir-close-throws
branch
from
b0b499f
to
1fb210c
Compare
|
Thanks, learned a lot about how to test Node.js. The code has been updated @aduh95 |
aduh95
approved these changes
Nov 25, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Nov 26, 2020
ZYSzys
approved these changes
Nov 26, 2020
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36243 ✔ Done loading data for nodejs/node/pull/36243 ----------------------------------- PR info ------------------------------------ Title fs/dir: pass the error to the callback or Promise.catch if already closed (#36243) Author Lxxyx (@Lxxyx, first-time contributor) Branch Lxxyx:fix/dir-close-throws -> nodejs:master Labels author ready, fs Commits 1 - fs/dir: pass the error to the callback or Promise.catch if already cl… Committers 1 - Zijian Liu PR-URL: https://github.com/nodejs/node/pull/36243 Fixes: https://github.com/nodejs/node/issues/36237 Reviewed-By: Antoine du Hamel Reviewed-By: Joyee Cheung Reviewed-By: Rich Trott Reviewed-By: Yongsheng Zhang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36243 Fixes: https://github.com/nodejs/node/issues/36237 Reviewed-By: Antoine du Hamel Reviewed-By: Joyee Cheung Reviewed-By: Rich Trott Reviewed-By: Yongsheng Zhang -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-11-25T15:23:50Z: https://ci.nodejs.org/job/node-test-pull-request/34556/ - Querying data for job/node-test-pull-request/34556/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Tue, 24 Nov 2020 06:32:49 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36243#pullrequestreview-538317002 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/36243#pullrequestreview-538603019 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36243#pullrequestreview-539312063 ✔ - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/36243#pullrequestreview-539441282 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36243 From https://github.com/nodejs/node * branch refs/pull/36243/merge -> FETCH_HEAD ✔ Fetched commits as b4c2ff5a3bb5..1fb210c50356 -------------------------------------------------------------------------------- [master 7e448d0bca] fs/dir: pass the error to the callback or Promise.catch if already closed Author: Zijian Liu Date: Tue Nov 24 14:30:26 2020 +0800 2 files changed, 32 insertions(+), 8 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- ⚠ Found Fixes: https://github.com/nodejs/node/issues/36237, skipping.. --------------------------------- New Message ---------------------------------- fs/dir: pass the error to the callback or Promise.catch if already closedhttps://github.com/nodejs/node/actions/runs/387516680 |
Lxxyx
changed the title
|
Tried to update the name of Pull Request to avoid "Commit Queue failed" error. @aduh95 |
|
Landed in b938f88 |
aduh95
force-pushed
the
fix/dir-close-throws
branch
from
1fb210c
to
b938f88
Compare
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
Pass the error to the callback or returns a rejected Promise instead of throwing a synchonous error. Fixes: #36237 PR-URL: #36243 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Pass the error to the callback or returns a rejected Promise instead of throwing a synchonous error. Fixes: #36237 PR-URL: #36243 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous functions should forward errors via callback.
In the case of Promise, errors can be caught with Promise.catch
Fixes: #36237
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes