Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky sequential/test-fs-watch #36249

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2020

Fixes: #36247

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2020
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Nov 24, 2020

@Trott
Copy link
Member Author

Trott commented Nov 24, 2020

I ran tools/test.py --repeat 1000 ./node test/sequential/test-fs-watch.js locally on master and on this PR. Master failed 4 times. This PR had no failures.

@Trott
Copy link
Member Author

Trott commented Nov 25, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/206/

So this fixes the existing flakiness but introduces a different problem in that now it sometimes fails because it gets a rename event rather than a change event. That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.

@Trott
Copy link
Member Author

Trott commented Nov 25, 2020

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Nov 25, 2020

That's another OS-specific weirdness thing but I'll see if we can get it to be consistently change.

The fixup commit fixed it locally and on CI.

Fixes: nodejs#36247

PR-URL: nodejs#36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 27, 2020

Landed in 8ba65b5

@Trott Trott merged commit 8ba65b5 into nodejs:master Nov 27, 2020
@Trott Trott deleted the watch-interval branch November 27, 2020 13:03
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky sequential/test-fs-watch
4 participants