-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky sequential/test-fs-watch #36249
Conversation
I ran |
So this fixes the existing flakiness but introduces a different problem in that now it sometimes fails because it gets a |
The fixup commit fixed it locally and on CI. |
Fixes: nodejs#36247 PR-URL: nodejs#36249 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
a28a2df
to
8ba65b5
Compare
Landed in 8ba65b5 |
Fixes: #36247
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes