Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: move definition from header file #36256

Merged
merged 1 commit into from
Nov 29, 2020
Merged

fs: move definition from header file #36256

merged 1 commit into from
Nov 29, 2020

Commits on Nov 29, 2020

  1. fs: move method definition from header 

    We are defining the definition of function in the header file itself. It
should be defined in the source file instead of the header file.

PR-URL: nodejs#36256
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @yashLadha @Trott
    yashLadha authored and Trott committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    9bf12df View commit details
    Browse the repository at this point in the history