-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process: refactor to use more primordials #36269
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
Issues and PRs related to the child_process subsystem.
label
Nov 25, 2020
Lxxyx
force-pushed
the
child_process-primordials
branch
from
November 27, 2020 05:20
085d730
to
d1e3196
Compare
aduh95
reviewed
Nov 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please remove the unrelated changes, and I've also let a comment on an optimisation we can make.
Lxxyx
force-pushed
the
child_process-primordials
branch
from
November 27, 2020 13:58
d1e3196
to
95ece51
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The benchmark suite is crashing before completion, I've opened #36295 to fix that. |
Benchmark results:
|
aduh95
approved these changes
Dec 2, 2020
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 2, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 2, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 3, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 3, 2020
Landed in a897a25...f7dd330 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
PR-URL: #36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
added
dont-land-on-v12.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v14.x
labels
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes