Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: refactor to use more primordials #36296

Closed
wants to merge 1 commit into from
Closed

readline: refactor to use more primordials #36296

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 27, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Nov 27, 2020
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34633/ ✅

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

Landed in e074bee...ed6e71a

@github-actions github-actions bot closed this Dec 4, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 4, 2020
@aduh95 @nodejs-github-bot
readline: refactor to use more primordials
ed6e71a 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 deleted the readline-primordials branch December 4, 2020 18:35
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
readline: refactor to use more primordials
b885409 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@aduh95 @cjihrig
readline: refactor to use more primordials
31d6721 
PR-URL: nodejs#36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
readline: refactor to use more primordials
efbec9d 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
readline: refactor to use more primordials
b5b8a99 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@juanarbol
Copy link
Member

Hey, this is breaking in the v16.x release branch by the avoid-prototype-pollution lint rule; I was considering doing something like you did on this line: https://github.com/nodejs/node/pull/43476/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0R34; simply commenting the linter. But this is not my code; I decided to request a backport fo v16.x

@juanarbol
Copy link
Member

Nevermind, this is a quite all commit; this is part of v16.x branch already.

@juanarbol juanarbol mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @juanarbol @Trott