Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http2-respond-file-error-pipe-offset #36305

Merged
merged 0 commits into from
Dec 7, 2020
Merged

test: fix flaky test-http2-respond-file-error-pipe-offset #36305

merged 0 commits into from
Dec 7, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 28, 2020

Fixes: #35881

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 28, 2020
@Trott Trott mentioned this pull request Nov 28, 2020
Closed
@Trott Trott changed the title test: fix falky test-http2-respond-file-error-pipe-offset test: fix flaky test-http2-respond-file-error-pipe-offset Nov 28, 2020
@Trott Trott requested a review from addaleax November 28, 2020 16:38
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@szmarczak
Copy link
Member

Can't we use a UNIX socket instead?

@Trott
Copy link
Member Author

Trott commented Dec 2, 2020

Can't we use a UNIX socket instead?

I'm under the impression that the test is specifically for an issue involving pipes, but I could be wrong. /ping @addaleax

addaleax
addaleax approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as would be using a socket. The important thing is that the target file is not seekable.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34729/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34742/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34748/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34767/

@Trott Trott closed this Dec 7, 2020
@Trott Trott merged commit f178c5a into nodejs:master Dec 7, 2020
@Trott
Copy link
Member Author

Trott commented Dec 7, 2020

Landed in f178c5a

@Trott Trott deleted the sprig branch December 7, 2020 15:31
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
test: fix flaky test-http2-respond-file-error-pipe-offset
a7e794d 
Fixes: #35881

PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@Trott @cjihrig
test: fix flaky test-http2-respond-file-error-pipe-offset
c9c72eb 
Fixes: nodejs#35881

PR-URL: nodejs#36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 25, 2021
@Trott @targos
test: fix flaky test-http2-respond-file-error-pipe-offset
cd1da67 
Fixes: #35881

PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-respond-file-error-pipe-offset
4 participants
@Trott @nodejs-github-bot @szmarczak @addaleax