Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix comment misspellings of transferred #36360

Merged
merged 1 commit into from
Dec 7, 2020
Merged

test: fix comment misspellings of transferred #36360

merged 1 commit into from
Dec 7, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 3, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Dec 3, 2020
@Trott Trott mentioned this pull request Dec 3, 2020
Closed
2 tasks
danbev
danbev approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@danbev danbev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I only searched the src directory and should have searched everything.

@Trott
Copy link
Member Author

Trott commented Dec 3, 2020

Sorry, I only searched the src directory and should have searched everything.

I suppose. On the other hand, I'm OK with having src cleaned up in one PR and test in another, so...
¯\(ツ)/¯

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34703/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34727/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34749/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34766/

@Trott
test: fix comment misspellings of transferred
5122456 
PR-URL: nodejs#36360
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@Trott Trott merged commit 5122456 into nodejs:master Dec 7, 2020
@Trott
Copy link
Member Author

Trott commented Dec 7, 2020

Landed in 5122456

@Trott Trott deleted the transferred branch December 7, 2020 15:51
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@Trott @danielleadams
test: fix comment misspellings of transferred
b39d150 
PR-URL: #36360
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@Trott @cjihrig
test: fix comment misspellings of transferred
11effd7 
PR-URL: nodejs#36360
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: fix comment misspellings of transferred
736b575 
PR-URL: #36360
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@himself65 himself65 himself65 approved these changes

@richardlau richardlau richardlau approved these changes

@watilde watilde watilde approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @danbev @watilde @richardlau @himself65 @aduh95