Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise addon mulitple initializations text #36457

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 9, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Dec 9, 2020
@Trott
Copy link
Member Author

Trott commented Dec 11, 2020

@nodejs/documentation

PR-URL: nodejs#36457
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 15, 2020

Landed in 850c466

@Trott Trott merged commit 850c466 into nodejs:master Dec 15, 2020
@Trott Trott deleted the addon-inits branch December 15, 2020 11:41
targos pushed a commit that referenced this pull request Dec 21, 2020
PR-URL: #36457
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36457
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants