Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update terminology #36475

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

Signed-off-by: Michael Dawson mdawson@devrus.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 10, 2020
@addaleax
Copy link
Member

👍 to fast-track

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. doc Issues and PRs related to the documentations. labels Dec 10, 2020
@mhdawson
Copy link
Member Author

I think based on the fast track rules this can now land. Since doc only just need the linters which have passed as well. Will land.

mhdawson added a commit that referenced this pull request Dec 10, 2020
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #36475
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 72b07e4

@mhdawson mhdawson closed this Dec 10, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #36475
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #36475
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants