tools: revise line in configure.py for clarity #36551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Trott
added
the
python
richardlau
approved these changes
Dec 17, 2020
aduh95
approved these changes
Dec 17, 2020
lpinca
approved these changes
Dec 17, 2020
github-actions
bot
removed
the
request-ci
watilde
approved these changes
Dec 18, 2020
|
Landed in 083abe2 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
* Replace unused identifier with Python convention `_`. * Remove unneeded parentheses. * Remove line-wrapping. I confirmed that this doesn't change the output by running `./configure --shared-zlib` and confirming that it created the same `common.gypi` with and without these changes. The code changed here doesn't run unless there is a `--shared-*` flag. PR-URL: #36551 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
* Replace unused identifier with Python convention `_`. * Remove unneeded parentheses. * Remove line-wrapping. I confirmed that this doesn't change the output by running `./configure --shared-zlib` and confirming that it created the same `common.gypi` with and without these changes. The code changed here doesn't run unless there is a `--shared-*` flag. PR-URL: #36551 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_.I confirmed that this doesn't change the output by running
./configure --shared-zliband confirming that it created the samecommon.gypiwith and without these changes. The code changed here doesn't run unless
there is a
--shared-*flag.Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes