-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use _code name_ rather than _codename_ #36611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you be adding codename/codenames to the list of prohibited strings?
I wasn't planning on it but now that you mention it, I suppose it makes sense. |
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: nodejs#36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Landed in 4d3e87d |
Doing that will flag line 76 of the README so that will need to be worked out first: alias for the latest Current release. The latest-_codename_ directory is an |
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: #36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This is excrutiatingly minor, but every authoritative resource I've checked (which is to say, a few dictionaries) uses "code name" primarily or exclusively. Let's follow suit. PR-URL: #36611 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This is excrutiatingly minor, but every authoritative resource I've
checked (which is to say, a few dictionaries) uses "code name" primarily
or exclusively. Let's follow suit.
Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes