Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: revise install.py for minor improvements #36626

Merged
merged 1 commit into from
Dec 27, 2020
Merged

tools: revise install.py for minor improvements #36626

merged 1 commit into from
Dec 27, 2020

Commits on Dec 27, 2020

  1. tools: revise install.py for minor improvements 

    * Use an with block for reading the config file.
Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files

* Use explicit blank return to make it clear that the return value is
  not actually used and that it is being used for flow control only..

PR-URL: nodejs#36626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
    @Trott
    Trott committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    245159f View commit details
    Browse the repository at this point in the history