build, tools, win: check if python is a executable program #36696

himself65 · 2020-12-30T16:26:57Z

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters.

Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update

before install python

after

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

tools/msvs/find_python.cmd

Trott · 2021-01-09T06:24:50Z

@nodejs/platform-windows

gengjiawen · 2021-11-18T02:02:20Z

run into this on a fresh windows. Why MS did this ...

nodejs-github-bot · 2021-11-18T02:07:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40954/

himself65 · 2021-11-18T19:19:30Z

run into this on a fresh windows. Why MS did this ...

Maybe they think that they're helping people to download the correct python🤔

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters. Fixes: nodejs#36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update

Co-authored-by: Rich Trott <rtrott@gmail.com>

himself65 · 2021-11-19T17:58:20Z

rebasing

nodejs-github-bot · 2021-11-19T18:22:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41003/

nodejs-github-bot · 2021-11-24T23:48:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41085/

nodejs-github-bot · 2022-01-18T17:56:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42001/

nodejs-github-bot · 2022-01-29T01:20:39Z

Commit Queue failed

- Loading data for nodejs/node/pull/36696 ✔ Done loading data for nodejs/node/pull/36696 ----------------------------------- PR info ------------------------------------ Title build, tools, win: check if python is a executable program (#36696) Author Himself65 (@Himself65) Branch Himself65:20201231-fix-find_python -> nodejs:master Labels windows, install, build, tools, author ready Commits 2 - build, tools, win: check if python is a executable program - fixup! Committers 1 - himself65 PR-URL: https://github.com/nodejs/node/pull/36696 Fixes: https://github.com/nodejs/node/issues/36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update Reviewed-By: Jiawen Geng Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36696 Fixes: https://github.com/nodejs/node/issues/36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update Reviewed-By: Jiawen Geng Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 30 Dec 2020 16:26:57 GMT ✔ Approvals: 2 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36696#pullrequestreview-809374093 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36696#pullrequestreview-866765180 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-18T17:56:33Z: https://ci.nodejs.org/job/node-test-pull-request/42001/ - Querying data for job/node-test-pull-request/42001/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 36696 From https://github.com/nodejs/node * branch refs/pull/36696/merge -> FETCH_HEAD ✔ Fetched commits as d86dcaa631df..0b5251c46d5a -------------------------------------------------------------------------------- Auto-merging tools/msvs/find_python.cmd [master 1084527c28] build, tools, win: check if python is a executable program Author: himself65 Date: Thu Dec 31 00:23:40 2020 +0800 1 file changed, 11 insertions(+) Auto-merging tools/msvs/find_python.cmd [master 03cf3a2011] fixup! Author: Himself65 Date: Sat Jan 9 18:34:00 2021 +0800 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
⚠ Found Fixes: #36694, skipping..
⚠ Found Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update, skipping..
--------------------------------- New Message ----------------------------------
build, tools, win: check if python is a executable program

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters.

Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update

PR-URL: #36696
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 4a5825299c] build, tools, win: check if python is a executable program
Author: himself65 himself65@outlook.com
Date: Thu Dec 31 00:23:40 2020 +0800
1 file changed, 11 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!

Co-authored-by: Rich Trott rtrott@gmail.com

PR-URL: #36696
Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 1922acc4ac] fixup!
Author: Himself65 himself65@outlook.com
Date: Sat Jan 9 18:34:00 2021 +0800
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/1764418351

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters. Fixes: #36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update PR-URL: #36696 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

gengjiawen · 2022-01-29T01:40:15Z

landed in 2818fa6

gengjiawen · 2022-01-29T01:41:37Z

@richardlau Sorry missing the new labels. I have landed it manually using node-core-utils

nodejs-github-bot · 2022-01-29T01:42:53Z

Commit Queue failed

- Loading data for nodejs/node/pull/36696
✔  Done loading data for nodejs/node/pull/36696
----------------------------------- PR info ------------------------------------
Title      build, tools, win: check if python is a executable program (#36696)
Author     Himself65  (@Himself65)
Branch     Himself65:20201231-fix-find_python -> nodejs:master
Labels     windows, install, build, tools, author ready
Commits    2
 - build, tools, win: check if python is a executable program
 - fixup!
Committers 1
 - himself65 
PR-URL: https://github.com/nodejs/node/pull/36696
Fixes: https://github.com/nodejs/node/issues/36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
Reviewed-By: Jiawen Geng 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36696
Fixes: https://github.com/nodejs/node/issues/36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
Reviewed-By: Jiawen Geng 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 30 Dec 2020 16:26:57 GMT
   ✔  Approvals: 2
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36696#pullrequestreview-809374093
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36696#pullrequestreview-866765180
   ⚠  This PR was closed on Sat, 29 Jan 2022 01:40:15 GMT
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-01-29T01:20:39Z: https://ci.nodejs.org/job/node-test-pull-request/42001/
- Querying data for job/node-test-pull-request/42001/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1764466725

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters. Fixes: nodejs#36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update PR-URL: nodejs#36696 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters. Fixes: #36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update PR-URL: #36696 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 30, 2020

himself65 force-pushed the 20201231-fix-find_python branch from ef21ecb to 4446e9a Compare December 30, 2020 16:29

himself65 changed the title ~~build,win: check if python is a executable program~~ build, tools, win: check if python is a executable program Dec 30, 2020

himself65 force-pushed the 20201231-fix-find_python branch from 4446e9a to 4dfdb67 Compare December 30, 2020 16:38

PoojaDurgad added the build Issues and PRs related to build files or the CI. label Jan 1, 2021

Trott reviewed Jan 9, 2021

View reviewed changes

tools/msvs/find_python.cmd Outdated Show resolved Hide resolved

guybedford force-pushed the master branch from dc5a5da to 8e46568 Compare March 29, 2021 21:33

gengjiawen approved these changes Nov 18, 2021

View reviewed changes

gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 18, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2021

github-actions bot mentioned this pull request Nov 19, 2021

CI Reliability 2021-11-19 nodejs/reliability#122

Open

31 tasks

himself65 and others added 2 commits November 19, 2021 11:58

fixup!

0b5251c

Co-authored-by: Rich Trott <rtrott@gmail.com>

himself65 force-pushed the 20201231-fix-find_python branch from 9761fc4 to 0b5251c Compare November 19, 2021 17:58

github-actions bot mentioned this pull request Nov 25, 2021

CI Reliability 2021-11-25 nodejs/reliability#128

Open

38 tasks

mhdawson mentioned this pull request Dec 16, 2021

Investigate flaky test - parallel/test-repl-sigint-nested-eval #41210

Closed

This was referenced Dec 17, 2021

CI Reliability 2021-12-17 nodejs/reliability#147

Open

CI Reliability 2021-12-18 nodejs/reliability#148

Open

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022

jasnell approved these changes Jan 28, 2022

View reviewed changes

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 29, 2022

gengjiawen closed this Jan 29, 2022

gengjiawen removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 29, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 29, 2022

himself65 deleted the 20201231-fix-find_python branch January 30, 2022 20:16

ruyadorno mentioned this pull request Feb 8, 2022

v17.5.0 release proposal #41897

Merged

danielleadams mentioned this pull request Mar 3, 2022

v16.14.1 release proposal #42200

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build, tools, win: check if python is a executable program #36696

build, tools, win: check if python is a executable program #36696

himself65 commented Dec 30, 2020 •

edited

Loading

Trott commented Jan 9, 2021

gengjiawen commented Nov 18, 2021

nodejs-github-bot commented Nov 18, 2021

himself65 commented Nov 18, 2021

himself65 commented Nov 19, 2021

nodejs-github-bot commented Nov 19, 2021

nodejs-github-bot commented Nov 24, 2021

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 29, 2022

PR-URL: #36696
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #36696
Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

gengjiawen commented Jan 29, 2022

gengjiawen commented Jan 29, 2022

nodejs-github-bot commented Jan 29, 2022

build, tools, win: check if python is a executable program #36696

build, tools, win: check if python is a executable program #36696

Conversation

himself65 commented Dec 30, 2020 • edited Loading

Checklist

Trott commented Jan 9, 2021

gengjiawen commented Nov 18, 2021

nodejs-github-bot commented Nov 18, 2021

himself65 commented Nov 18, 2021

himself65 commented Nov 19, 2021

nodejs-github-bot commented Nov 19, 2021

nodejs-github-bot commented Nov 24, 2021

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 29, 2022

PR-URL: #36696 Reviewed-By: Jiawen Geng technicalcute@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #36696 Fixes: #36694 Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update Reviewed-By: Jiawen Geng technicalcute@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

gengjiawen commented Jan 29, 2022

gengjiawen commented Jan 29, 2022

nodejs-github-bot commented Jan 29, 2022

himself65 commented Dec 30, 2020 •

edited

Loading

PR-URL: #36696
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #36696
Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com