Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in esm documentation #36800

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix typo in esm documentation #36800

merged 1 commit into from
Jan 5, 2021

Conversation

kamagatos
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 5, 2021
RaisinTen
RaisinTen suggested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe change the commit message to:

doc: fix typo in esm.md

@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2021

nit: maybe change the commit message to:

doc: fix typo in esm.md

This can be done by whoever lands this, our policy is to lift that kind of burden off first-time contributors 😉

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 5, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2021

Fast-track?

@kamagatos @aduh95
doc: fix typo in esm documentation
3c49ee2 
PR-URL: #36800
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@aduh95 aduh95 merged commit 3c49ee2 into nodejs:master Jan 5, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2021

Landed in 3c49ee2 🎉 Thanks for the contribution!

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@kamagatos @danielleadams
doc: fix typo in esm documentation
fad07d5 
PR-URL: #36800
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@kamagatos @targos
doc: fix typo in esm documentation
8f48e77 
PR-URL: #36800
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen requested changes

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

@aduh95 aduh95 aduh95 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kamagatos @aduh95 @richardlau @gireeshpunathil @BethGriggs @RaisinTen @PoojaDurgad @nodejs-github-bot