Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use faster variant for rss in test-net-bytes-per-incoming-chunk-overhead.js #36839

Merged
merged 1 commit into from
Apr 3, 2021
Merged

test: use faster variant for rss in test-net-bytes-per-incoming-chunk-overhead.js #36839

merged 1 commit into from
Apr 3, 2021

Conversation

PoojaDurgad
Copy link
Contributor

Refs: #34291

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 8, 2021
@PoojaDurgad PoojaDurgad force-pushed the rss-bytes branch 2 times, most recently from ee0ffc1 to 1a406d0 Compare January 8, 2021 05:58
@PoojaDurgad PoojaDurgad added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@PoojaDurgad
Copy link
Contributor Author

is there anything pending on this PR? if yes let me know

@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Mar 29, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37065/

@Flarna
Copy link
Member

Flarna commented Mar 31, 2021

There is a github action fail. Seems unrelated but according to our guideline landing is not allowed with such fails.
There are enough approvals and Jenkins CI is also green.

Maybe try to rebase which should retrigger github actions.

@PoojaDurgad @aduh95
test: use faster variant for rss
4ad7338 
PR-URL: nodejs#36839
Refs: nodejs#34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 merged commit 4ad7338 into nodejs:master Apr 3, 2021
@aduh95
Copy link
Contributor

aduh95 commented Apr 3, 2021

Tests are passing after rebase. Landed in 4ad7338

MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@PoojaDurgad @MylesBorins
test: use faster variant for rss
6bf507f 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Merged
MylesBorins pushed a commit that referenced this pull request Apr 5, 2021
@PoojaDurgad @MylesBorins
test: use faster variant for rss
0243376 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad @targos
test: use faster variant for rss
45bf825 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@PoojaDurgad @BethGriggs
test: use faster variant for rss
91f0046 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
@PoojaDurgad @MylesBorins
test: use faster variant for rss
b643fe7 
PR-URL: #36839
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@PoojaDurgad @foxxyz
test: use faster variant for rss
132c8a3 
PR-URL: nodejs#36839
Refs: nodejs#34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PoojaDurgad @nodejs-github-bot @Flarna @aduh95 @jasnell @targos