Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove outdated V8 flag #37151

Closed
wants to merge 1 commit into from
Closed

test: remove outdated V8 flag #37151

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 30, 2021

The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3

@targos
test: remove outdated V8 flag
f97690c 
The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35829/

richardlau
richardlau approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to keep the flag on the older V8 versions and don’t want this backported?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35831/

targos added a commit that referenced this pull request Feb 2, 2021
@targos
test: remove outdated V8 flag
501ae0e 
The flag is going to be removed upstream in V8 9.0.

Refs: v8/v8@0a480c3

PR-URL: #37151
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos
Copy link
Member Author

targos commented Feb 2, 2021

Landed in 501ae0e

@targos targos closed this Feb 2, 2021
@targos targos deleted the remove-v8-flag branch February 2, 2021 09:34
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @jasnell @Trott @benjamingr @cjihrig @gengjiawen @richardlau @gireeshpunathil @RaisinTen