crypto: fix and simplify prime option validation #37164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
commented
Feb 1, 2021
| if (bigint < 0) { | ||
| throw new ERR_OUT_OF_RANGE(name, '>= 0', bigint); | ||
| } | ||
|
|
||
| const hex = bigint.toString(16); |
There was a problem hiding this comment.
Explanation: The value hex begins with a minus sign if bigint < 0, causing Buffer.from(hex, 'hex') to return an empty buffer, which OpenSSL treats as a 0.
|
Ping @nodejs/crypto |
jasnell
approved these changes
Feb 6, 2021
tniessen
added
the
author ready
Trott
approved these changes
Feb 6, 2021
PR-URL: nodejs#37164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
crypto-prime-handle-negative-bigint
branch
from
a6664c8
to
406984e
Compare
|
Landed in 406984e |
tniessen
removed
the
author ready
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37164 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the handling of negative
BigInts in thegeneratePrimeandgeneratePrimeSyncfunctions and adds tests for these cases.Additionally, it extracts the logic to set up the
RandomPrimeJobto a new function to eliminate duplicate code.