-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: add import assertion support #37176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
vm
Issues and PRs related to the vm subsystem.
labels
Feb 1, 2021
devsnek
added
the
esm
Issues and PRs related to the ECMAScript Modules implementation.
label
Feb 1, 2021
cjihrig
reviewed
Feb 1, 2021
devsnek
force-pushed
the
vm-import-assertion
branch
from
February 1, 2021 22:29
91e224b
to
a290d09
Compare
addaleax
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with a comment to avoid crashing in cases of prototype pollution addressed)
devsnek
force-pushed
the
vm-import-assertion
branch
from
February 5, 2021 06:36
a290d09
to
4c489f2
Compare
devsnek
force-pushed
the
vm-import-assertion
branch
from
March 23, 2021 00:16
4c489f2
to
d6b0b14
Compare
devsnek
force-pushed
the
vm-import-assertion
branch
from
March 23, 2021 00:22
d6b0b14
to
84cdb17
Compare
targos
approved these changes
Mar 23, 2021
PR-URL: nodejs#37176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek
force-pushed
the
vm-import-assertion
branch
from
March 23, 2021 16:04
84cdb17
to
26eed3e
Compare
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
PR-URL: #37176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
hi @devsnek this commit is breaking |
@ruyadorno nope! its stuck to the v8 version in master 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft until our V8 is new enough to support this.