-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mark Certificate methods as static, add missing KeyObject.from #37198
Conversation
eae8700
to
5218bbe
Compare
5218bbe
to
9396d6d
Compare
I realize that this has landed and was released, but regarding
Not really related to the changes in this PR though, at least the function won't be undocumented anymore. |
@tniessen would you like to introduce a specifically named method instead and mark this one deprecated? Either way i think this doc update should land. |
That depends. It works and there is no ambiguity when it comes to the input. We can reuse the same function with different signatures for other inputs. It depends on what other input forms we want to allow in the future. What about JWK, for example? If we allow In the other PR (#37218), adding If we never want to allow anything but uniquely identifiable types, such as |
(Approving under the assumption that #37240 will update the docs accordingly.) |
Landed in e8286bb |
PR-URL: #37198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #37198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
cc @jasnell @tniessen