tools: fix d8 macOS build #37211
Closed
tools: fix d8 macOS build #37211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libv8_base doesn't exist anymore.
cjihrig
approved these changes
Feb 3, 2021
|
How far back should this be backported? |
|
I don't know, but this doesn't have to be backported, unless someone needs to build d8 on an older branch. |
evanlucas
approved these changes
Feb 4, 2021
gengjiawen
approved these changes
Feb 4, 2021
Trott
approved these changes
Feb 6, 2021
targos
added a commit
that referenced
this pull request
Feb 7, 2021
libv8_base doesn't exist anymore. PR-URL: #37211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 907d6b6 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
libv8_base doesn't exist anymore. PR-URL: #37211 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libv8_base doesn't exist anymore.