Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: explain the unused argument in IncomingMessage._read #37275

Closed
wants to merge 4 commits into from
Closed

http: explain the unused argument in IncomingMessage._read #37275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3736fb9
http: remove unused parameter in _read of IncomingMessage
Ayase-252 Feb 8, 2021
28bc61b
Revert "http: remove unused parameter in _read of IncomingMessage"
Ayase-252 Feb 8, 2021
3bc6cfa
http: explain the unused argument in IncomingMessage._read
Ayase-252 Feb 8, 2021
f1cfe2a
http: explain the possibilty of refactor unused argument
Ayase-252 Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/_http_incoming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,14 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
return this;
};


// Argument n cannot be factored out due to the overhead of
// argument adaptor frame creation inside V8 in case that number of actual
// arguments is different from expected arguments.
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9.
// Refactoring `n` out might be possible when V8 is upgraded to that
// version.
// Ref: https://v8.dev/blog/v8-release-89
IncomingMessage.prototype._read = function _read(n) {
if (!this._consuming) {
this._readableState.readingMore = false;
Expand Down