Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixed typos in api/console.md and api/crypto.md #37279

Merged
merged 2 commits into from
Feb 8, 2021
Merged

doc: fixed typos in api/console.md and api/crypto.md #37279

merged 2 commits into from
Feb 8, 2021

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Feb 8, 2021

In doc/api/console.md -> 'displayed' is spelled as 'diplayed'
In doc/api/crypto.md -> 'occurred' is spelled as 'occured'

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 8, 2021
@aduh95
Copy link
Contributor

aduh95 commented Feb 8, 2021

fast-track?

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2021
PR-URL: #37279
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #37279
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott Trott merged commit 2dfd000 into nodejs:master Feb 8, 2021
@Trott
Copy link
Member

Trott commented Feb 8, 2021

Landed in 044110e...2dfd000.

Welcome, and thanks for the contribution! 🎉

@marsonya marsonya deleted the doc-typo-fix-2 branch February 9, 2021 02:39
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37279
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37279
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This was referenced Feb 16, 2021
@nodejs-github-bot
Copy link
Collaborator

targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37279
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants