Policy scope fix #37298
Closed
Policy scope fix #37298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
confirmed-bug
bmeck
force-pushed
the
policy-scope-fix
branch
from
718f600
to
d74f91e
Compare
marsonya
approved these changes
Feb 10, 2021
bmeck
added
the
author ready
|
CI failure seems to be flaking and not related to this PR. Will merge in a few unless otherwise commented |
|
ah, nm needs 1 more collab approval, missed that (will go poking around for one) |
jasnell
reviewed
Feb 14, 2021
jasnell
reviewed
Feb 14, 2021
jasnell
approved these changes
Feb 14, 2021
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
|
CI issues seem unrelated, going to merge in a bit |
bmeck
added a commit
that referenced
this pull request
Feb 15, 2021
PR-URL: #37298 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com>
|
|
Landed in f24e707 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37298 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37298 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com>
Merged
This was referenced Jan 13, 2023
Open
This was referenced Apr 18, 2023
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where repeated scope lookup for modules with multiple dependencies would fail and the manifest would look up the dependency redirector of the referrer rather than the scope. This was found in stress testing of https://github.com/bmeck/local-fs-https-imports . The reason it didn't appear to have a test before is likely that code coverage was unaffected.