Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: check ed/x webcrypto key import algorithm names #37305

Merged
merged 1 commit into from
Feb 26, 2021
Merged

crypto: check ed/x webcrypto key import algorithm names #37305

merged 1 commit into from
Feb 26, 2021
+125 −14

Conversation

panva
Copy link
Member

@panva panva commented Feb 10, 2021 •
edited
Loading

This fixes a couple things in the webcrypto experimental module

  • makes sure Ed* keys algorithms are NODE-ED*
  • makes sure X* keys algorithms are ECDH
  • doc change to clarify the nodeEdKeyImportParams.public parameter is only used with the raw format.

Previously you couldn't import these using the node.keyObject format at all despite the support matrix saying so.

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Feb 10, 2021
@panva panva requested a review from jasnell February 10, 2021 11:31
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36334/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36335/

@panva @aduh95
crypto: check ed/x webcrypto key import algorithm names
8ddee73 
PR-URL: nodejs#37305
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Feb 26, 2021

Landed in 8ddee73

@aduh95 aduh95 merged commit 8ddee73 into nodejs:master Feb 26, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
@panva @targos
crypto: check ed/x webcrypto key import algorithm names
291d9e9 
PR-URL: #37305
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
@panva panva deleted the more-edx-import-fixes branch October 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @aduh95 @jasnell @targos