Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix typo in natural-compare/README.md #37366

Closed
wants to merge 1 commit into from
Closed

tools: fix typo in natural-compare/README.md #37366

wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

comparision -> comparison

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 14, 2021
@RaisinTen
Copy link
Contributor

I believe this change should be done at natural-compare's own repo: https://github.com/litejs/natural-compare-lite

@targos
Copy link
Member

targos commented Feb 14, 2021

Yes, sorry @eltociear, we cannot accept this change because it's in a dependency that we include without modifications.

@targos targos closed this Feb 14, 2021
@targos targos added the wrong repo Issues that should be opened in another repository. label Feb 14, 2021
@eltociear
Copy link
Contributor Author

@RaisinTen @targos Thanks announcement!
I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory. wrong repo Issues that should be opened in another repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eltociear @RaisinTen @targos @nodejs-github-bot