Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: simplify check in child_process #37367

Closed

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Feb 14, 2021
@nodejs-github-bot
Copy link
Collaborator

@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 14, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/36129/ (:heavy_check_mark:)

RaisinTen added a commit that referenced this pull request Feb 16, 2021
PR-URL: #37367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RaisinTen
Copy link
Contributor Author

Landed in 7b17705

@RaisinTen RaisinTen closed this Feb 16, 2021
@RaisinTen RaisinTen deleted the lib/simplify-check-in-child-process branch February 16, 2021 15:12
@RaisinTen
Copy link
Contributor Author

@Lxxyx I'm sorry, I forgot to add your name to the list of reviewers in this commit! Should I amend the commit and force push?

RaisinTen added a commit to RaisinTen/node that referenced this pull request Feb 16, 2021
PR-URL: nodejs#37367
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RaisinTen
Copy link
Contributor Author

Landed in 549a11c

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37367
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37367
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants