Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clarify usage of tmpdir.refresh() #37383

Merged
merged 1 commit into from
Feb 22, 2021
Merged

test: clarify usage of tmpdir.refresh() #37383

merged 1 commit into from
Feb 22, 2021
+6 −1

Conversation

RaisinTen
Copy link
Contributor

This emphasizes that tmpdir.refresh() must be called only once in each
test file when needed.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 15, 2021
@RaisinTen RaisinTen added the doc Issues and PRs related to the documentations. label Feb 16, 2021
Trott
Trott reviewed Feb 17, 2021
View reviewed changes
test/common/README.md Outdated Show resolved Hide resolved
@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2021
@RaisinTen @aduh95
test: clarify usage of tmpdir.refresh()
127f47e 
This emphasizes that `tmpdir.refresh()` must be called only once in each
test file when needed.

PR-URL: nodejs#37383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@aduh95 aduh95 force-pushed the test,doc/clarify-usage-of-tmpdir-refresh branch from 1f6ae87 to 127f47e Compare February 22, 2021 11:23
@aduh95
Copy link
Contributor

aduh95 commented Feb 22, 2021

Landed in 127f47e

@aduh95 aduh95 merged commit 127f47e into nodejs:master Feb 22, 2021
@RaisinTen RaisinTen deleted the test,doc/clarify-usage-of-tmpdir-refresh branch February 22, 2021 11:43
targos pushed a commit that referenced this pull request Feb 28, 2021
@RaisinTen @targos
test: clarify usage of tmpdir.refresh()
b569105 
This emphasizes that `tmpdir.refresh()` must be called only once in each
test file when needed.

PR-URL: #37383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
test: clarify usage of tmpdir.refresh()
776ef11 
This emphasizes that `tmpdir.refresh()` must be called only once in each
test file when needed.

PR-URL: #37383
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RaisinTen @aduh95 @jasnell @Trott @lpinca @gireeshpunathil @Lxxyx @nodejs-github-bot