Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use createDeferredPromise() in promises.watch() #37386

Merged
merged 1 commit into from
Feb 18, 2021
Merged

fs: use createDeferredPromise() in promises.watch() #37386

merged 1 commit into from
Feb 18, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 15, 2021

This commit updates fsPromises.watch() to use the createDeferredPromise() utility.

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Feb 15, 2021
benjamingr
benjamingr approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this pattern because of safety - but the refactoring doesn't really change the code it just uses a utility.

jasnell
jasnell approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I hadn't seen that the utility had already landed.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36154/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36159/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36160/

@RaisinTen
Copy link
Contributor

I think this should be rebased to include 1c6484b for a green CI.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36186/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 17, 2021 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36187/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2021
@cjihrig
fs: use createDeferredPromise() in promises.watch()
9a2ac2c 
This commit updates fsPromises.watch() to use the
createDeferredPromise() utility.

PR-URL: nodejs#37386
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@cjihrig cjihrig merged commit 9a2ac2c into nodejs:master Feb 18, 2021
@cjihrig cjihrig deleted the deferred branch February 18, 2021 04:35
targos pushed a commit that referenced this pull request Feb 28, 2021
@cjihrig @targos
fs: use createDeferredPromise() in promises.watch()
d141fce 
This commit updates fsPromises.watch() to use the
createDeferredPromise() utility.

PR-URL: #37386
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @RaisinTen @jasnell @benjamingr @lpinca @targos