Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: apply sentence case to headers in doc/guides #37478

Closed
wants to merge 1 commit into from
Closed

doc: apply sentence case to headers in doc/guides #37478

wants to merge 1 commit into from

Conversation

marsonya
Copy link
Member

@marsonya marsonya commented Feb 22, 2021 •
edited
Loading

in accordance to doc styling guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 22, 2021
jasnell
jasnell approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please 👍🏻 to fast-track

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 23, 2021
@jasnell
Copy link
Member

jasnell commented Feb 23, 2021

Landed in aecae19

@jasnell jasnell closed this Feb 23, 2021
jasnell pushed a commit that referenced this pull request Feb 23, 2021
@marsonya @jasnell
doc: apply sentence case to headers in doc/guides
aecae19 
PR-URL: #37478
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 28, 2021
@marsonya @targos
doc: apply sentence case to headers in doc/guides
834f637 
PR-URL: #37478
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya @targos
doc: apply sentence case to headers in doc/guides
099eef6 
PR-URL: #37478
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
This was referenced Apr 18, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Apr 18, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 18, 2023
Open
This was referenced Apr 19, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Apr 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marsonya @jasnell @Trott @lpinca @RaisinTen @nodejs-github-bot