Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: "director" instead of "directory" #37523

Closed
wants to merge 1 commit into from
Closed

Fix typo: "director" instead of "directory" #37523

wants to merge 1 commit into from

Conversation

humanwebpl
Copy link
Contributor

Change fs.readdirSync() description from "Reads the contents of the director." to "Reads the contents of the directory."

@humanwebpl
Fix typo: "director" instead of "directory"
1ec8a89 
Change fs.readdirSync() description from "Reads the contents of the director." to "Reads the contents of the directory."
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 26, 2021
@RaisinTen
Copy link
Contributor

Duplicate of #37522?

Trott
Trott approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but this is a duplicate of the change in #37522 so only one or the other will land.

@jasnell
Copy link
Member

jasnell commented Mar 1, 2021

Landed in 1ca4a9c

@jasnell jasnell closed this Mar 1, 2021
jasnell pushed a commit that referenced this pull request Mar 1, 2021
@humanwebpl @jasnell
doc: fix typo "director" instead of "directory"
1ca4a9c 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
@humanwebpl @lpinca
doc: fix typo "director" instead of "directory"
796504d 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: nodejs#37523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 2, 2021
@humanwebpl @targos
doc: fix typo "director" instead of "directory"
dd7a04d 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@humanwebpl @targos
doc: fix typo "director" instead of "directory"
bbcc217 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Flarna Flarna Flarna approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@humanwebpl @RaisinTen @jasnell @Trott @benjamingr @targos @Flarna @HarshithaKP @nodejs-github-bot