-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THP ELF assembly: Add .note.GNU-stack section #37688
THP ELF assembly: Add .note.GNU-stack section #37688
Conversation
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building. Refs: #17933
It looks like Theory, based on the error message: For reference since the build logs may disappear, the error message is:
|
Landed in 90008f8. |
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: #17933 Related: #37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #38312 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
While @progbits is preferred for most architectures, there are some (notably 32-bit ARM) for which it does not. %progbits is effective everywhere. See https://bugzilla.redhat.com/show_bug.cgi?id=1950528 for more details. Related: nodejs/node#17933 Related: nodejs/node#37688 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
This indicates to GNU binutils that it can unset the executable stack flag on the binary that it is building.
Refs: #17933
cc @gabrielschulhof @bnoordhuis (from the
git
shortlog in this part of the codebase)cc @danbev (as discussed, for review)
Two developer notes to aid review:
%progbits
with a percentage symbol. The approach here uses@progbits
instead, which is the form documented in thebinutils
documentation here.node
is a cross-platform binary and I believe this section could be relevant for other platforms.Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.