Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: request default snap track be updated for LTS #37708

Closed
wants to merge 1 commit into from
Closed

doc: request default snap track be updated for LTS #37708

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Mar 11, 2021

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2021
@rvagg rvagg force-pushed the rvagg/lts-snap branch 2 times, most recently from 19eb4bf to 9c75b2b Compare April 26, 2021 06:50
@rvagg
Copy link
Member Author

rvagg commented Apr 26, 2021

/r @nodejs/lts @nodejs/build perhaps?

@rvagg
Copy link
Member Author

rvagg commented Apr 26, 2021

My ncu config is messed up somehow and I don't have time to figure it out just now. Would someone who's setup for landing and has good muscle memory for landing PRs to make it trivial mind landing this for me? I do it so infrequently that it's getting difficult each time I have to come back and set it up and figure it out.

targos pushed a commit that referenced this pull request Apr 27, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
9b878ec 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Apr 27, 2021

Landed in 9b878ec

@targos targos closed this Apr 27, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
bcc5e2a 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
cd25868 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
14df46d 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
50bcea6 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@rvagg @targos
doc: request default snap track be updated for LTS
c03f23e 
PR-URL: #37708
Refs: nodejs/snap#4
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCripps AshCripps AshCripps approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@targos targos targos approved these changes

@codebytere codebytere codebytere approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rvagg @targos @jasnell @codebytere @BethGriggs @AshCripps @nodejs-github-bot