Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert,util: fix commutativity edge case #37711

Merged
merged 1 commit into from
Mar 13, 2021
Merged

assert,util: fix commutativity edge case #37711

merged 1 commit into from
Mar 13, 2021

Conversation

BridgeAR
Copy link
Member

Verify that both objects property keys are enumerable.

Fixes: #37710

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Mar 11, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36673/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36678/

@BridgeAR @aduh95
assert,util: fix commutativity edge case
5ff2e58 
Verify that both objects property keys are enumerable.

Fixes: nodejs#37710

PR-URL: nodejs#37711
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the fix-comparisons-communtativity branch from 9248e4d to 5ff2e58 Compare March 13, 2021 12:44
@aduh95
Copy link
Contributor

aduh95 commented Mar 13, 2021

Landed in 5ff2e58

@aduh95 aduh95 merged commit 5ff2e58 into nodejs:master Mar 13, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@BridgeAR @danielleadams
assert,util: fix commutativity edge case
ce8ac4d 
Verify that both objects property keys are enumerable.

Fixes: #37710

PR-URL: #37711
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@BridgeAR @danielleadams
assert,util: fix commutativity edge case
4451460 
Verify that both objects property keys are enumerable.

Fixes: #37710

PR-URL: #37711
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@BridgeAR @targos
assert,util: fix commutativity edge case
9fb10dc 
Verify that both objects property keys are enumerable.

Fixes: #37710

PR-URL: #37711
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepStrictEqual not commutative by not accounting for non-enumerable properties
6 participants
@BridgeAR @nodejs-github-bot @aduh95 @Trott @benjamingr @lpinca