lib: use AbortError consistently #37715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
events
Collaborator
aduh95
approved these changes
Mar 11, 2021
jasnell
added
the
author ready
Collaborator
trivikr
approved these changes
Mar 12, 2021
Trott
approved these changes
Mar 13, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37715 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
use-aborterror-consistently
branch
from
7401105 to
886516a
Compare
Member
|
Landed in 886516a |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37715 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37715 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates unnecessary boilerplate and code duplication
Signed-off-by: James M Snell jasnell@gmail.com