doc: clarify when child process 'spawn' event is *not* emitted #37833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this clarification in response to a comment on GitHub: nodejs#35288 (comment)
nodejs-github-bot
added
child_process
cjihrig
approved these changes
Mar 20, 2021
benjamingr
approved these changes
Mar 20, 2021
marsonya
approved these changes
Mar 21, 2021
jasnell
approved these changes
Mar 22, 2021
|
Landed in 3b3838d |
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2021
Making this clarification in response to a comment on GitHub: #35288 (comment) PR-URL: #37833 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
Making this clarification in response to a comment on GitHub: #35288 (comment) PR-URL: #37833 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Making this clarification in response to a comment on GitHub: #35288 (comment) PR-URL: #37833 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this clarification in response to a comment on GitHub:
#35288 (comment)