Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: fix pre-aborted AbortSignal question handling #37929

Closed

Conversation

Linkgoron
Copy link
Member

@Linkgoron Linkgoron commented Mar 26, 2021

question in readline was missing pre-aborted AbortSignal handling. I'm not sure if the behaviour for the callback version is confusing or not (if the signal is already aborted, just return and do nothing) - so thoughts are welcome.

fix pre-aborted question handling
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Mar 26, 2021
@nodejs-github-bot
Copy link
Collaborator

lib/readline.js Outdated Show resolved Hide resolved
@Linkgoron Linkgoron force-pushed the readline-question-pre-abort-signal branch from f10ef73 to a676afe Compare March 26, 2021 17:36
@nodejs-github-bot
Copy link
Collaborator

@Linkgoron Linkgoron added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2021
jasnell pushed a commit that referenced this pull request Apr 1, 2021
fix pre-aborted question handling

PR-URL: #37929
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 1, 2021

Landed in dbab289

@jasnell jasnell closed this Apr 1, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
fix pre-aborted question handling

PR-URL: #37929
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants