dns: default to verbatim=true in dns.lookup() #37931

treysis · 2021-03-26T16:14:14Z

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.)

After many tests failed due to differently resolving localhost to ::1 or 127.0.0.1 and after it became impossible to keep track of what worked and what didn't in the CI jobs during running the test suite, this is a fresh start from what we learned in, and effectively a reissue of #37681.

Fixes: #31566
Refs: #6307
Refs: #20710
Reissue of #31567

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681

nodejs-github-bot · 2021-03-26T17:27:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36998/

treysis · 2021-03-27T18:43:17Z

So, I went again through any single test that failed on my machine and tried to fix it. I found the following tests to fail and did the following to fix them. Let's also have a CI job to see what problems exist on the other setups.

Explanations:

test/parallel/test-cluster-message.js: add family: 4 to connect because without it will default to localhost which could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/parallel/test-http-localaddress.js: add family: 4, to connect because localhost could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/parallel/test-http-upgrade-client.js: add family: 4, to http.get because http.get without specified host uses localhost which could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/parallel/test-http2-connect-options.js: add family: 4 to http2.connect options because localhost might resolve to ::1 if IPv6 is available, causing EINVAL when binding to 127.0.0.2, and server listen address is hardcoded legacy IPv4.
test/parallel/test-https-localaddress.js: add family: 4 to https.request options because localhost might resolve to ::1 if IPv6 is available, causing EINVAL when binding to 127.0.0.2, and server listen address is hardcoded legacy IPv4.
test/common/inspector-helper.js: add family: 4 to http.get options to make sure to connect via legacy IPv4 localhost, because inspector by default listens on legacy IPv4 localhost. Fixes:
- test/parallel/test-inspect-async-hook-setup-at-inspect.js
- test/parallel/test-inspector-esm.js
- test/parallel/test-inspector-inspect-brk-node.js
- test/parallel/test-inspector-multisession-ws.js
- test/parallel/test-inspector-reported-host.js
- test/parallel/test-inspector-wait-for-connection.js
- test/parallel/test-inspector-waiting-for-disconnect.js
- test/sequential/test-inspector.js
- test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js
- test/sequential/test-inspector-async-hook-setup-at-signal.js
- test/sequential/test-inspector-async-stack-traces-promise-then.js
- test/sequential/test-inspector-async-stack-traces-set-interval.js
- test/sequential/test-inspector-break-e.js
- test/sequential/test-inspector-break-when-eval.js
- test/sequential/test-inspector-console.js
- test/sequential/test-inspector-debug-brk-flag.js
- test/sequential/test-inspector-debug-end.js
- test/sequential/test-inspector-exception.js
- test/sequential/test-inspector-not-blocked-on-idle.js
- test/sequential/test-inspector-scriptparsed-context.js
- test/sequential/test-inspector-stop-profile-after-done.js
- test/sequential/test-inspector-stress-http.js
test/parallel/test-net-dns-lookup.js: listen on common.localhostIPv4 and add family: 4 to connect to force legacy IPv4, because it is required by the assertion tests. Could be changed to DualStack compatibility by using assert.match(ip, /^(127\.0\.0\.1|::1)$/); and assert.match(type.toString, /^(4|6)$/);.
test/parallel/test-net-remote-address-port.js: add ::1 to remoteAddrCandidates. Why does this fix it?
test/parallel/test-tcp-wrap-listen.js: add ternary test with hasIPv6 and use bind or bind6 accordingly.
test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js: add family: 4 to connect because it will default to localhost being ::1 if IPv6 is available, and listen address is hardcoded to be legacy IPv4 address for localhost.
test/parallel/test-tls-client-getephemeralkeyinfo.js: add family: 4 to connect because without it will default to localhost which could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/parallel/test-tls-client-mindhsize.js: add family: 4 to connect because without it will default to localhost which could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/parallel/test-tls-wrap-econnreset-localaddress.js: add family: 4 to connect because without it will default to localhost which could resolve to ::1 if IPv6 is available, while server listen address is hardcoded legacy IPv4.
test/sequential/test-https-connect-localport.js: remove family: 4 from connect because listen uses localhost which maybe resolves to ::1? NEEDS TESTING! If it fails --> force legacy IPv4 with common.localhostIPv4.
test/sequential/test-inspector-open.js: add family: 4 to connect because without it will default to localhost which could resolve to ::1 if IPv6 is available, while inspector is listening on legacy IPv4 localhost by default.
test/sequential/test-net-connect-local-error.js: add family: 4 to optionsIPv4 and family: 6 to optionsIPv6, because it seems connecting on IPv4 will default to localhost which then resolves to ::1 if IPv6 is available and will cause an error.

Explanations: ------------- test/parallel/test-cluster-message.js: add `family: 4` to `connect` because without it will default to `localhost` which could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/parallel/test-http-localaddress.js: add `family: 4,` to `connect` because `localhost` could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/parallel/test-http-upgrade-client.js: add `family: 4,` to `http.get` because `http.get` without specified host uses `localhost` which could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/parallel/test-http2-connect-options.js: add `family: 4` to `http2.connect` `options` because `localhost` might resolve to `::1` if IPv6 is available, causing `EINVAL` when binding to `127.0.0.2`, and server listen address is hardcoded legacy IPv4. test/parallel/test-https-localaddress.js: add `family: 4` to `https.request` `options` because `localhost` might resolve to `::1` if IPv6 is available, causing `EINVAL` when binding to `127.0.0.2`, and server listen address is hardcoded legacy IPv4. test/common/inspector-helper.js: add `family: 4` to `http.get` options to make sure to connect via legacy IPv4 `localhost`, because inspector by default listens on legacy IPv4 `localhost`. Fixes: test/parallel/test-inspect-async-hook-setup-at-inspect.js test/parallel/test-inspector-esm.js test/parallel/test-inspector-inspect-brk-node.js test/parallel/test-inspector-multisession-ws.js test/parallel/test-inspector-reported-host.js test/parallel/test-inspector-wait-for-connection.js test/parallel/test-inspector-waiting-for-disconnect.js test/sequential/test-inspector.js test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js test/sequential/test-inspector-async-hook-setup-at-signal.js test/sequential/test-inspector-async-stack-traces-promise-then.js test/sequential/test-inspector-async-stack-traces-set-interval.js test/sequential/test-inspector-break-e.js test/sequential/test-inspector-break-when-eval.js test/sequential/test-inspector-console.js test/sequential/test-inspector-debug-brk-flag.js test/sequential/test-inspector-debug-end.js test/sequential/test-inspector-exception.js test/sequential/test-inspector-not-blocked-on-idle.js test/sequential/test-inspector-scriptparsed-context.js test/sequential/test-inspector-stop-profile-after-done.js test/sequential/test-inspector-stress-http.js test/parallel/test-net-dns-lookup.js: listen on `common.localhostIPv4` and add `family: 4` to `connect` to force legacy IPv4, because it is required by the assertion tests. Could be changed to DualStack compatibility by using `assert.match(ip, /^(127\.0\.0\.1|::1)$/);` and `assert.match(type.toString, /^(4|6)$/);`. test/parallel/test-net-remote-address-port.js: add `::1` to `remoteAddrCandidates`. Why does this fix it? test/parallel/test-tcp-wrap-listen.js: add ternary test with `hasIPv6` and use `bind` or `bind6` accordingly. test/parallel/test-timers-socket-timeout-removes-other-socket-unref-timer.js: add `family: 4` to `connect` because it will default to localhost being `::1` if IPv6 is available, and listen address is hardcoded to be legacy IPv4 address for `localhost`. test/parallel/test-tls-client-getephemeralkeyinfo.js: add `family: 4` to `connect` because without it will default to `localhost` which could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/parallel/test-tls-client-mindhsize.js: add `family: 4` to `connect` because without it will default to `localhost` which could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/parallel/test-tls-wrap-econnreset-localaddress.js: add `family: 4` to `connect` because without it will default to `localhost` which could resolve to `::1` if IPv6 is available, while server listen address is hardcoded legacy IPv4. test/sequential/test-https-connect-localport.js: remove `family: 4` from connect because listen uses `localhost` which maybe resolves to `::1`? NEEDS TESTING! If it fails --> force legacy IPv4 with `common.localhostIPv4`. test/sequential/test-inspector-open.js: add `family: 4` to `connect` because without it will default to `localhost` which could resolve to `::1` if IPv6 is available, while inspector is listening on legacy IPv4 `localhost` by default. test/sequential/test-net-connect-local-error.js: add `family: 4` to `optionsIPv4` and `family: 6` to `optionsIPv6`, because it seems connecting on IPv4 will default to `localhost` which then resolves to `::1` if IPv6 is available and will cause an error.

doc/api/dns.md

nodejs-github-bot · 2021-03-27T18:59:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/37024/

treysis · 2021-03-27T19:44:25Z

Alright, so the preliminary results confirm something that I was suspecting. While we could replace 127.0.0.1 in probably all instances with localhost, this will break many tests on SmartOS. The reason is what we have found out and discussed in the previous PR: SmartOS can resolve localhost to ::1 when trying to open a listening socket. But it will refuse to resolve localhost to ::1 when opening a connection if there is no configured IPv6 address other than ::1, and instead resolves to 127.0.0.1.

Thus, I see two options:

Apply a more general approach using localhost in favor of 127.0.0.1 and mark all those tests flaky for SmartOS, or
Force IPv4 on all systems where SmartOS otherwise fails.

In my opinion, the way to go currently is approach 2. Approach 1 should be something implemented in a separate PR that tries to be more DualStack-aware. In approach 1 it would probably also make sense to review the implementation of DNS resolution on listening and connecting and to make sure they resolve to the same values.

treysis · 2021-03-27T21:57:15Z

SmartOS fixes:

test/parallel/test-net-connect-options-port.js: add family: 4 at various places to force localhost or default localhost to be resolved to legacy IPv4 addresses.
test/parallel/test-net-pingpong.js: change localhost to 127.0.0.1 because test is aimed at legacy IPv4, so it can be forced to literal IPv4 address without problem. NEEDS TESTING: does pingPongTest(0); pass?
test/parallel/test-net-remote-address-port.js: change localhost to 127.0.0.1 and force IPv4 by adding family: 4 because SmartOS will resolve localhost or no address automatically to legacy IPv4 address (127.0.0.1).
test/parallel/test-net-writable.js: listen on common.localhostIPv4 and add family: 4 to connect to force IPv4. because SmartOS will resolve localhost or no address automatically to legacy IPv4 address (127.0.0.1).
test/sequential/test-https-connect-localport.js: revert previous change, i.e. readd family: 4 to https.get. Change localhost on listen to common.localhostIPv4 to force legacy IPv4.

Explanations: test/parallel/test-net-connect-options-port.js: add `family: 4` at various places to force `localhost` or default `localhost` to be resolved to legacy IPv4 addresses. test/parallel/test-net-pingpong.js: change `localhost` to `127.0.0.1` because test is aimed at legacy IPv4, so it can be forced to literal IPv4 address without problem. NEEDS TESTING: does `pingPongTest(0);` pass? test/parallel/test-net-remote-address-port.js: change `localhost` to `127.0.0.1` and force IPv4 by adding `family: 4` because SmartOS will resolve `localhost` or no address automatically to legacy IPv4 address (`127.0.0.1`). test/parallel/test-net-writable.js: listen on `common.localhostIPv4` and add `family: 4` to connect to force IPv4. because SmartOS will resolve `localhost` or no address automatically to legacy IPv4 address (`127.0.0.1`). test/sequential/test-https-connect-localport.js: revert previous change, i.e. readd `family: 4` to `https.get`. Change `localhost` on listen to `common.localhostIPv4` to force legacy IPv4.

aduh95 · 2021-03-27T22:34:11Z

FWIW I don't think modifying the tests just so they can pass on SmartOS is OK. Depending on the cause of the failure:

If this is an issue with our CI configuration, we should mark the tests as flaky on SmartOS and try to fix them later.
If this is an issue with SmartOS itself, we should report the issue to them and hold on landing this until a fix is available.

Either way, I don't think modifying failing tests is the right thing to do here. @nodejs/platform-smartos wdyt?

The changes in bdedf3a LGTM though (thanks for the detailed explanation BTW, that's really good work).

treysis · 2021-03-27T22:50:50Z

If this is an issue with our CI configuration, we should mark the tests as flaky on SmartOS and try to fix them later.

If this is an issue with SmartOS itself, we should report the issue to them and hold on landing this until a fix is available.

I think it's both. Refusing to use ::1 when connecting to localhost while no other IPv6 address configured seems to be inherent to SmartOS. I don't know if this might even be a general thing on Unix>BSD>Solaris. I created a VM with SmartOS and ping -s localhost would use 127.0.0.1, while ping -s -A inet6 localhost would fail with unknown host despite having ::1 localhost in /etc/hosts, and ifconfig showing ::1 being assigned to lo. It would work as soon as there's another IPv6 address configured. I don't think anyone is really going to change this.

On the other hand, I don't understand why it is binding fine to ::1 when specifying localhost in this situation. In my opinion this shouldn't be happening, and I am not sure yet if this is related to NodeJS, or SmartOS.

The changes in bdedf3a LGTM though (thanks for the detailed explanation BTW, that's really good work).

Without the explanations I probably would have lost track myself. It was necessary to have an overview over what needs to be addressed. But thanks for the acknowledgement.

treysis · 2021-03-28T00:23:13Z

Do the Linux CIs have IPv6 connectivity? Even though I don't really want to admit it...if I remove the public IPv6 address on my system, I observe the same problem as on SmartOS: listening on localhost means binding to ::1, connecting to localhost means connecting to 127.0.0.1.

I am not sure if this is related to the DNS module or to the resolver of the OS. If I do ping localhost it will always do ping ::1 on my system (Linux Mint), no matter if public IPv6 configured or not.

Edit: Thinking a bit about it I think we should adjust the tests. There is the chance (in theory) that having an IPv6 address configured or not might change during runtime. Since we can't listen DualStack on localhost, it makes sense to force the few tests to IPv4. I actually also don't see any reason why those tests use localhost instead of the hardcoded 127.0.0.1 that most of the other tests use anyways.

Edit2: It's related to getaddrinfo() and is the expected behavior if loopback is the only IPv6 address on the system: https://man7.org/linux/man-pages/man3/getaddrinfo.3.html

treysis · 2021-03-28T19:38:47Z

I think we should ditch AF_ADDRCONFIG. This was already suggested by @bnoordhuis in the previous discussions, and has been suggested in other projects not related to NodeJS as well.

On another node, @bnoordhuis also suggested ditching common.localhostIPv4 and replace it by hardcoded 127.0.0.1, as this method is just unnecessary.

A commit will follow shortly.

This reverts commit a45f066.

treysis · 2021-03-28T22:15:23Z

Can we get another CI job?

nodejs-github-bot · 2021-03-28T22:23:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/37032/

treysis · 2021-03-28T23:34:15Z

Great! So, what else needs to be discussed now in order to merge this?

What should be mentioned in the documentation: usage of localhost should be discouraged. Use 127.0.0.1 or ::1.

test/sequential/test-https-connect-localport.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

mhdawson · 2021-04-12T15:10:54Z

I'm in agreement with @mcollina suggestion - #37931 (comment) as a way to make landing the change feasible.

treysis · 2021-04-12T15:37:35Z

What I am asking is a way to change the default globally, i.e. require('dns').verbatim = true

Is this kind of syntax supported by NodeJS/Javascript?

addaleax · 2021-04-12T15:55:33Z

What I am asking is a way to change the default globally, i.e. require('dns').verbatim = true

Is this kind of syntax supported by NodeJS/Javascript?

Yes.

That being said, this might be a case where an environment variable seems like a better choice (because it is configurable from outside the process, which is relevant because this affects users just as much as it does developers, and because that way it is inherited by Workers and child processes by default).

treysis · 2021-04-12T16:07:29Z

Yes.

Thx. Unfortunately, I haven't been able to find some example code how to do this. Still, I can't even find any documentation of this syntax.

That being said, this might be a case where an environment variable seems like a better choice (because it is configurable from outside the process, which is relevant because this affects users just as much as it does developers, and because that way it is inherited by Workers and child processes by default).

Yes. But maybe we can implement both solutions. The inside process option to make it easier for the devs (though I feel this might lead to some devs just setting it 'to be sure' and never touching it again), and the outside option with higher precedence to eventually let the user decide.

treysis · 2021-04-12T18:54:20Z

I am not very well versed in Javascript. I believe we have to do sth like this:

// lib/dns.js
...
let verbatim = true;
if (this.verbatimglobal == false) {
  verbatim = false;
  options.verbatim = false;
}
...

// any app that uses NodeJS' dns module:
var dns = require('dns');
dns.verbatimglobal = false;

But that throws an error/warning if dns.verbatimglobal is not set.

I couldn't find a way to make var dns = require('dns').verbatim = false work.

aduh95 · 2021-04-13T17:51:35Z

I couldn't find a way to make require('dns').verbatim = false work.

Implementation is done in #38099, once it has landed it should unblock this PR.

mhdawson · 2021-04-15T20:19:40Z

Was discussed in the TSC meeting today. From those who were there (only a small subset) consensus was that the opt-in approach would be ok. That can be landed after 16.x is released, likely too late for a SemVer major version as it's unlikely that we can reach consensus.

@mcollina should this still stay on the TSC agenda or is that the feedback you were looking for.

mcollina · 2021-04-15T23:11:34Z

removed!

treysis · 2021-04-16T12:14:27Z

So as I understand 'opt-in' means v16 will allow global configuration of the verbatim order, but for v16 it will still default to false?

jasnell · 2021-04-16T12:29:07Z

Yes that is correct

treysis · 2021-04-16T12:35:28Z

I think it would be great to have a way for the user to configure the behavior via environment-variables until this PR lands.

aduh95 · 2021-06-02T18:25:22Z

@treysis Would you be interested in resurrecting this PR now that #38099 has landed?

mcollina · 2021-06-02T18:26:32Z

I'm +1 for this landing as the default in Node v17.

treysis · 2021-06-02T18:56:07Z

Of course. I have loosely been monitoring the other PR. But it might take me some days until I can have a look at it, understand what exactly the other PR did, and adjust to the changes.

aduh95 · 2021-09-03T14:19:59Z

@treysis as a heads up, Node.js v17.x semver cutoff is getting close (around September 19th I think, the release date is scheduled for October 19th). If you were able to rebase your branch on top on master, we could have this change included in 17.0.0.

treysis · 2021-09-03T14:31:37Z

@aduh85 Thx. I was about to dive into it again already the past days but didn't find the time/motivation yet. The upcoming deadline might be just what is needed :)

treysis · 2021-09-03T20:04:34Z

Before I submit a new PR...where is the getDefaultVerbatim getting its value from? I guess I should leave it like that in the code and change whatever defines getDefaultVerbatim, right? I think it's in lib/internal/dns/utils.js line 189?

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: nodejs#31566 Refs: nodejs#6307 Refs: nodejs#20710 Refs: nodejs#38099 Reissue of nodejs#31567 Reissue of nodejs#37681 Reissue of nodejs#37931

Switch the default from false (reorder the result so that IPv4 addresses come before IPv6 addresses) to true (return them exactly as the resolver sent them to us.) Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reissue of #31567 Reissue of #37681 Reissue of #37931 PR-URL: #39987 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

aduh95 · 2021-09-12T19:18:29Z

Superseded by 1b2749e.

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Mar 26, 2021

treysis force-pushed the verbatim-true-reissue branch from 5bef0de to 90a5e93 Compare March 26, 2021 16:17

treysis mentioned this pull request Mar 26, 2021

dns: default to verbatim=true in dns.lookup() #37681

Closed

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 26, 2021

aduh95 reviewed Mar 27, 2021

View reviewed changes

doc/api/dns.md Outdated Show resolved Hide resolved

treysis force-pushed the verbatim-true-reissue branch from 5f24bef to bdedf3a Compare March 27, 2021 18:45

Adjust doc/api/dns.md

88d5f24

treysis force-pushed the verbatim-true-reissue branch from 130edc7 to a45f066 Compare March 27, 2021 22:03

treysis mentioned this pull request Mar 27, 2021

localhost doesn't resolve to ::1, despite having the correct entry in /etc/hosts TritonDataCenter/smartos-live#982

Closed

treysis added 3 commits March 28, 2021 21:54

Revert "SmartOS fixes for the test suite"

ea90294

This reverts commit a45f066.

Remove dns.ADDRCONFIG from net.js

618579b

Fix test/sequential/test-tls-securepair-client.js

6667100

aduh95 approved these changes Mar 29, 2021

View reviewed changes

test/sequential/test-https-connect-localport.js Outdated Show resolved Hide resolved

Update test/sequential/test-https-connect-localport.js

5cc6082

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

mhdawson mentioned this pull request Apr 12, 2021

Node.js Technical Steering Committee (TSC) Meeting 2021-04-15 nodejs/TSC#1015

Closed

mcollina mentioned this pull request Apr 14, 2021

2021-04-20, Version 16.0.0 (Current) #37678

Merged

mcollina removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 15, 2021

aduh95 mentioned this pull request Jun 11, 2021

doc: deprecate type coercion for dns.lookup options #38906

Closed

aduh95 mentioned this pull request Aug 17, 2021

dns: runtime deprecate type coercion of dns.lookup options #39793

Closed

treysis mentioned this pull request Sep 3, 2021

dns: default to verbatim=true in dns.lookup() #39987

Closed

aduh95 closed this Sep 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dns: default to verbatim=true in dns.lookup() #37931

dns: default to verbatim=true in dns.lookup() #37931

treysis commented Mar 26, 2021 •

edited

Loading

nodejs-github-bot commented Mar 26, 2021

treysis commented Mar 27, 2021

nodejs-github-bot commented Mar 27, 2021

treysis commented Mar 27, 2021

treysis commented Mar 27, 2021

aduh95 commented Mar 27, 2021 •

edited

Loading

treysis commented Mar 27, 2021

treysis commented Mar 28, 2021 •

edited

Loading

treysis commented Mar 28, 2021 •

edited

Loading

treysis commented Mar 28, 2021

nodejs-github-bot commented Mar 28, 2021

treysis commented Mar 28, 2021 •

edited

Loading

mhdawson commented Apr 12, 2021

treysis commented Apr 12, 2021

addaleax commented Apr 12, 2021

treysis commented Apr 12, 2021 •

edited

Loading

treysis commented Apr 12, 2021 •

edited

Loading

aduh95 commented Apr 13, 2021

mhdawson commented Apr 15, 2021

mcollina commented Apr 15, 2021

treysis commented Apr 16, 2021

jasnell commented Apr 16, 2021

treysis commented Apr 16, 2021 •

edited

Loading

aduh95 commented Jun 2, 2021

mcollina commented Jun 2, 2021

treysis commented Jun 2, 2021

aduh95 commented Sep 3, 2021

treysis commented Sep 3, 2021

treysis commented Sep 3, 2021 •

edited

Loading

aduh95 commented Sep 12, 2021

dns: default to verbatim=true in dns.lookup() #37931

dns: default to verbatim=true in dns.lookup() #37931

Conversation

treysis commented Mar 26, 2021 • edited Loading

nodejs-github-bot commented Mar 26, 2021

treysis commented Mar 27, 2021

nodejs-github-bot commented Mar 27, 2021

treysis commented Mar 27, 2021

treysis commented Mar 27, 2021

aduh95 commented Mar 27, 2021 • edited Loading

treysis commented Mar 27, 2021

treysis commented Mar 28, 2021 • edited Loading

treysis commented Mar 28, 2021 • edited Loading

treysis commented Mar 28, 2021

nodejs-github-bot commented Mar 28, 2021

treysis commented Mar 28, 2021 • edited Loading

mhdawson commented Apr 12, 2021

treysis commented Apr 12, 2021

addaleax commented Apr 12, 2021

treysis commented Apr 12, 2021 • edited Loading

treysis commented Apr 12, 2021 • edited Loading

aduh95 commented Apr 13, 2021

mhdawson commented Apr 15, 2021

mcollina commented Apr 15, 2021

treysis commented Apr 16, 2021

jasnell commented Apr 16, 2021

treysis commented Apr 16, 2021 • edited Loading

aduh95 commented Jun 2, 2021

mcollina commented Jun 2, 2021

treysis commented Jun 2, 2021

aduh95 commented Sep 3, 2021

treysis commented Sep 3, 2021

treysis commented Sep 3, 2021 • edited Loading

aduh95 commented Sep 12, 2021

treysis commented Mar 26, 2021 •

edited

Loading

aduh95 commented Mar 27, 2021 •

edited

Loading

treysis commented Mar 28, 2021 •

edited

Loading

treysis commented Mar 28, 2021 •

edited

Loading

treysis commented Mar 28, 2021 •

edited

Loading

treysis commented Apr 12, 2021 •

edited

Loading

treysis commented Apr 12, 2021 •

edited

Loading

treysis commented Apr 16, 2021 •

edited

Loading

treysis commented Sep 3, 2021 •

edited

Loading