-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: correctly optimize debug function #37966
Conversation
Exporting a variable that will be mutated later doesn't work. Refs: nodejs#37937
@mcollina can you verify the fix on your benchmarking server? |
Yes it does but not completely. There are probably a few others but this does improve things if landed on top of #37963 (nothing otherwise as the other commit is a dominant bottleneck). |
Is still slightly faster than this fix alone (72k vs 70k). Can we add this as well? |
I can add it, but I honestly don't see how the difference can be measured, as this code path is hit only eight times during the entire process life, regardless of the number of HTTP requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'll check it further and verify again. |
This is ok to land, there are no other regression (I checked extensively) |
Exporting a variable that will be mutated later doesn't work. Refs: #37937 PR-URL: #37966 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 3dee233 |
Exporting a variable that will be mutated later doesn't work. Refs: #37937 PR-URL: #37966 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Exporting a variable that will be mutated later doesn't work.
Refs: #37937