Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to cjs-module-lexer@1.1.1 #37992

Closed
wants to merge 1 commit into from
Closed

deps: update to cjs-module-lexer@1.1.1 #37992

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

This updates to cjs-module-lexer@1.1.1, with the following patches:

Both are for Babel reexports patterns, backports will be necessary for compat.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 30, 2021
@guybedford
Copy link
Contributor Author

@nodejs/modules

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37066/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37070/

aduh95
aduh95 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This was referenced Mar 31, 2021
Closed
Closed
guybedford added a commit that referenced this pull request Apr 1, 2021
@guybedford
deps: update to cjs-module-lexer@1.1.1
0d66317 
PR-URL: #37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@guybedford
Copy link
Contributor Author

Landed in 0d66317.

@guybedford guybedford closed this Apr 1, 2021
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@guybedford @MylesBorins
deps: update to cjs-module-lexer@1.1.1
4ef102d 
PR-URL: #37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
Merged
guybedford added a commit that referenced this pull request Apr 14, 2021
@guybedford
deps: update to cjs-module-lexer@1.1.1
d56079a 
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@guybedford @richardlau
deps: update to cjs-module-lexer@1.1.1
7d5a2f9 
PR-URL: #37992
Backport-PR-URL: #38003
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guybedford @nodejs-github-bot @gengjiawen @aduh95 @targos