worker: fix exit code for error thrown in uncaughtException handler

[Linkgoron]

When an uncaughtException handler itself throws in a worker, the worker exits with an error code of 0 instead of 7 1, which happens because the worker thread global handler catches the error, and exitCode stays 0.

My fix only emits exit for "regular" unhandled exceptions (which shouldn't actually reach that code anyway, as it should set _exiting correctly in the "inner" handler) to emulate the same behaviour that happens in non-workers, where exit is not emitted when an error is thrown from a handler.

The process._exiting logic was essentially taken from here: https://github.com/nodejs/node/blob/master/lib/internal/process/execution.js#L167

Fixes: #37996

[Prinzhorn]

Thanks for fixing this so quickly. I think the docs need an update as well if we're going with 7 and not 1

If the worker was terminated, the exitCode parameter is 1.

https://nodejs.org/api/worker_threads.html#worker_threads_event_exit

[Linkgoron]

I've changed the exit code to 1 to conform with the documentation.

[Linkgoron]

@nodejs/workers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37206/ 💚

[jasnell]

Landed in 6986fa0

[Prinzhorn]

thanks!

Landed in 6986fa0

The 7 slipped in there again "from 0 to 7"

[Linkgoron]

thanks!

Landed in 6986fa0

The 7 slipped in there again "from 0 to 7"

Yeah, it looks like I missed amending the commit message. The PR is good though, and correctly exits with 1.